From: Wolfram Sang <wsa@the-dreams.de>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: linux-i2c@vger.kernel.org, Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH] i2c-mpc: Correct I2C reset procedure
Date: Thu, 11 May 2017 13:28:28 +0200 [thread overview]
Message-ID: <20170511112828.nwdmd7kqx3zciyaa@ninjato> (raw)
In-Reply-To: <20170509120351.28273-1-joakim.tjernlund@infinera.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Tue, May 09, 2017 at 02:03:51PM +0200, Joakim Tjernlund wrote:
> Current I2C reset procedure is broken in two ways:
> 1) It only generate 1 START instead of 9 STARTs and STOP.
> 2) It leaves the bus Busy so every I2C xfer after the first
> fixup calls the reset routine again, for every xfer there after.
>
> This fixes both errors. Add an iobarrier_rw() when writing the
> I2C control register as well to make sure the register reaches the
> controller in time.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
BTW can this driver be converted to make use of the bus_recovery
infrastructure?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-11 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 12:03 [PATCH] i2c-mpc: Correct I2C reset procedure Joakim Tjernlund
2017-05-09 20:54 ` Scott Wood
2017-05-10 7:02 ` Joakim Tjernlund
2017-05-11 1:42 ` Scott Wood
2017-05-11 11:23 ` Joakim Tjernlund
2017-05-11 11:28 ` Wolfram Sang [this message]
2017-05-11 11:42 ` [PATCH] " Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511112828.nwdmd7kqx3zciyaa@ninjato \
--to=wsa@the-dreams.de \
--cc=joakim.tjernlund@infinera.com \
--cc=linux-i2c@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.