From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:43222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755742AbdEKTtN (ORCPT ); Thu, 11 May 2017 15:49:13 -0400 Date: Thu, 11 May 2017 13:49:12 -0600 From: Pete Zaitcev To: Johan Hovold Cc: linux-usb@vger.kernel.org, stable Subject: Re: [PATCH 2/3] USB: serial: mct_u232: fix big-endian baud-rate handling Message-ID: <20170511134912.1d1eae05@lembas.zaitcev.lan> In-Reply-To: <20170511094121.21087-3-johan@kernel.org> References: <20170511094121.21087-1-johan@kernel.org> <20170511094121.21087-3-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 11 May 2017 11:41:20 +0200 Johan Hovold wrote: > Drop erroneous cpu_to_le32 when setting the baud rate, something which > corrupted the divisor on big-endian hosts. > +++ b/drivers/usb/serial/mct_u232.c > @@ -189,7 +189,7 @@ static int mct_u232_set_baud_rate(struct tty_struct *tty, > divisor = mct_u232_calculate_baud_rate(serial, value, &speed); > - put_unaligned_le32(cpu_to_le32(divisor), buf); > + put_unaligned_le32(divisor, buf); > rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), Acked-By: Pete Zaitcev -- Pete