From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v7 08/13] vfio/ccw: get io region info Date: Thu, 11 May 2017 15:48:39 -0600 Message-ID: <20170511154839.79768561@w520.home> References: <20170505020352.8984-1-bjsdjshi@linux.vnet.ibm.com> <20170505020352.8984-9-bjsdjshi@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170505020352.8984-9-bjsdjshi@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Dong Jia Shi Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.com, eric.auger@redhat.com List-ID: On Fri, 5 May 2017 04:03:47 +0200 Dong Jia Shi wrote: > vfio-ccw provides an MMIO region for I/O operations. We fetch its > information via ioctls here, then we can use it performing I/O > instructions and retrieving I/O results later on. > > Signed-off-by: Dong Jia Shi > --- Acked-by: Alex Williamson > hw/vfio/ccw.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 7d2497c..7ddcfd7 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -12,6 +12,7 @@ > */ > > #include > +#include > #include > > #include "qemu/osdep.h" > @@ -26,6 +27,9 @@ > typedef struct VFIOCCWDevice { > S390CCWDevice cdev; > VFIODevice vdev; > + uint64_t io_region_size; > + uint64_t io_region_offset; > + struct ccw_io_region *io_region; > } VFIOCCWDevice; > > static void vfio_ccw_compute_needs_reset(VFIODevice *vdev) > @@ -50,6 +54,48 @@ static void vfio_ccw_reset(DeviceState *dev) > ioctl(vcdev->vdev.fd, VFIO_DEVICE_RESET); > } > > +static void vfio_ccw_get_region(VFIOCCWDevice *vcdev, Error **errp) > +{ > + VFIODevice *vdev = &vcdev->vdev; > + struct vfio_region_info *info; > + int ret; > + > + /* Sanity check device */ > + if (!(vdev->flags & VFIO_DEVICE_FLAGS_CCW)) { > + error_setg(errp, "vfio: Um, this isn't a vfio-ccw device"); > + return; > + } > + > + if (vdev->num_regions < VFIO_CCW_CONFIG_REGION_INDEX + 1) { > + error_setg(errp, "vfio: Unexpected number of the I/O region %u", > + vdev->num_regions); > + return; > + } > + > + ret = vfio_get_region_info(vdev, VFIO_CCW_CONFIG_REGION_INDEX, &info); > + if (ret) { > + error_setg_errno(errp, -ret, "vfio: Error getting config info"); > + return; > + } > + > + vcdev->io_region_size = info->size; > + if (sizeof(*vcdev->io_region) != vcdev->io_region_size) { > + error_setg(errp, "vfio: Unexpected size of the I/O region"); > + g_free(info); > + return; > + } > + > + vcdev->io_region_offset = info->offset; > + vcdev->io_region = g_malloc0(info->size); > + > + g_free(info); > +} > + > +static void vfio_ccw_put_region(VFIOCCWDevice *vcdev) > +{ > + g_free(vcdev->io_region); > +} > + > static void vfio_put_device(VFIOCCWDevice *vcdev) > { > g_free(vcdev->vdev.name); > @@ -122,8 +168,15 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp) > goto out_device_err; > } > > + vfio_ccw_get_region(vcdev, &err); > + if (err) { > + goto out_region_err; > + } > + > return; > > +out_region_err: > + vfio_put_device(vcdev); > out_device_err: > vfio_put_group(group); > out_group_err: > @@ -142,6 +195,7 @@ static void vfio_ccw_unrealize(DeviceState *dev, Error **errp) > S390CCWDeviceClass *cdc = S390_CCW_DEVICE_GET_CLASS(cdev); > VFIOGroup *group = vcdev->vdev.group; > > + vfio_ccw_put_region(vcdev); > vfio_put_device(vcdev); > vfio_put_group(group); > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8vxJ-0003wp-0b for qemu-devel@nongnu.org; Thu, 11 May 2017 17:49:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8vxE-000151-1P for qemu-devel@nongnu.org; Thu, 11 May 2017 17:49:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41648) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8vxD-00013m-OB for qemu-devel@nongnu.org; Thu, 11 May 2017 17:48:59 -0400 Date: Thu, 11 May 2017 15:48:39 -0600 From: Alex Williamson Message-ID: <20170511154839.79768561@w520.home> In-Reply-To: <20170505020352.8984-9-bjsdjshi@linux.vnet.ibm.com> References: <20170505020352.8984-1-bjsdjshi@linux.vnet.ibm.com> <20170505020352.8984-9-bjsdjshi@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 08/13] vfio/ccw: get io region info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dong Jia Shi Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.com, eric.auger@redhat.com On Fri, 5 May 2017 04:03:47 +0200 Dong Jia Shi wrote: > vfio-ccw provides an MMIO region for I/O operations. We fetch its > information via ioctls here, then we can use it performing I/O > instructions and retrieving I/O results later on. > > Signed-off-by: Dong Jia Shi > --- Acked-by: Alex Williamson > hw/vfio/ccw.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 7d2497c..7ddcfd7 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -12,6 +12,7 @@ > */ > > #include > +#include > #include > > #include "qemu/osdep.h" > @@ -26,6 +27,9 @@ > typedef struct VFIOCCWDevice { > S390CCWDevice cdev; > VFIODevice vdev; > + uint64_t io_region_size; > + uint64_t io_region_offset; > + struct ccw_io_region *io_region; > } VFIOCCWDevice; > > static void vfio_ccw_compute_needs_reset(VFIODevice *vdev) > @@ -50,6 +54,48 @@ static void vfio_ccw_reset(DeviceState *dev) > ioctl(vcdev->vdev.fd, VFIO_DEVICE_RESET); > } > > +static void vfio_ccw_get_region(VFIOCCWDevice *vcdev, Error **errp) > +{ > + VFIODevice *vdev = &vcdev->vdev; > + struct vfio_region_info *info; > + int ret; > + > + /* Sanity check device */ > + if (!(vdev->flags & VFIO_DEVICE_FLAGS_CCW)) { > + error_setg(errp, "vfio: Um, this isn't a vfio-ccw device"); > + return; > + } > + > + if (vdev->num_regions < VFIO_CCW_CONFIG_REGION_INDEX + 1) { > + error_setg(errp, "vfio: Unexpected number of the I/O region %u", > + vdev->num_regions); > + return; > + } > + > + ret = vfio_get_region_info(vdev, VFIO_CCW_CONFIG_REGION_INDEX, &info); > + if (ret) { > + error_setg_errno(errp, -ret, "vfio: Error getting config info"); > + return; > + } > + > + vcdev->io_region_size = info->size; > + if (sizeof(*vcdev->io_region) != vcdev->io_region_size) { > + error_setg(errp, "vfio: Unexpected size of the I/O region"); > + g_free(info); > + return; > + } > + > + vcdev->io_region_offset = info->offset; > + vcdev->io_region = g_malloc0(info->size); > + > + g_free(info); > +} > + > +static void vfio_ccw_put_region(VFIOCCWDevice *vcdev) > +{ > + g_free(vcdev->io_region); > +} > + > static void vfio_put_device(VFIOCCWDevice *vcdev) > { > g_free(vcdev->vdev.name); > @@ -122,8 +168,15 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp) > goto out_device_err; > } > > + vfio_ccw_get_region(vcdev, &err); > + if (err) { > + goto out_region_err; > + } > + > return; > > +out_region_err: > + vfio_put_device(vcdev); > out_device_err: > vfio_put_group(group); > out_group_err: > @@ -142,6 +195,7 @@ static void vfio_ccw_unrealize(DeviceState *dev, Error **errp) > S390CCWDeviceClass *cdc = S390_CCW_DEVICE_GET_CLASS(cdev); > VFIOGroup *group = vcdev->vdev.group; > > + vfio_ccw_put_region(vcdev); > vfio_put_device(vcdev); > vfio_put_group(group); >