From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757091AbdEKRLq (ORCPT ); Thu, 11 May 2017 13:11:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:35318 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756168AbdEKRLp (ORCPT ); Thu, 11 May 2017 13:11:45 -0400 Date: Thu, 11 May 2017 19:11:43 +0200 From: "Luis R. Rodriguez" To: AKASHI Takahiro , "Luis R. Rodriguez" , gregkh@linuxfoundation.org, wagi@monom.org, dwmw2@infradead.org, rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net, yi1.li@linux.intel.com, atull@opensource.altera.com, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org, luto@kernel.org, dhowells@redhat.com, pjones@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/5] test: add new driver_data load tester Message-ID: <20170511171143.GV28800@wotan.suse.de> References: <20170330032514.17173-1-mcgrof@kernel.org> <20170330032514.17173-4-mcgrof@kernel.org> <20170411083248.GE15139@linaro.org> <20170428014535.GO28800@wotan.suse.de> <20170511104625.GF22134@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170511104625.GF22134@linaro.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > Luis, > > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > +To test an async call one could do:: > > > > + > > > > + echo anything > /lib/firmware/test-driver_data.bin > > > > > > Your current shell script doesn't search for the firmware in > > > /lib/firmware unless you explicitly specify $FWPATH. > > > > This is true but that is the *test* shell script, and it purposely avoids the > > existing firmware path to avoid overriding dummy test files on the production > > path. So the above still stands as it is not using the test shell script > > driver_data.sh. > > > > I'll add a note: > > > > """ > > Note that driver_data.sh uses its own temporary custom path for creating and > > looking for driver data files, it does this to not overwrite any production > > files you might have which may share the same names used by the test shell > > script driver_data.sh. If you are not using the driver_data.sh script your > > default path will be used. > > """ > > That looks fine, but I think we'd better change the line: > > > > > + echo anything > /lib/firmware/test-driver_data.bin > > since it is just incorrect as far as driver_data.sh goes. But that is accurate, given the default file we search for on test_driver_data.c is test-driver_data.bin. It also does not create a conflict to overwrite a file used on driver_data.sh as driver_data.sh uses a custom path. I think the note above on custom path is sufficient for the developer or user to be aware of the fact the driver_data.sh does it own thing, and that the example is just a manual test case. What do you mean by that its incorrect ? Luis