From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbdELISB (ORCPT ); Fri, 12 May 2017 04:18:01 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:49678 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdELIR6 (ORCPT ); Fri, 12 May 2017 04:17:58 -0400 Date: Fri, 12 May 2017 10:17:46 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Archit Taneja , Andrzej Hajda , Laurent Pinchart , CK Hu , Philipp Zabel , Yannick Fertre , Philippe Cornu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Message-ID: <20170512101746.17805ef8@bbrezillon> In-Reply-To: <20170511183128.25085-5-eric@anholt.net> References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev) > > DRM_INFO("ltdc hw version 0x%08x - ready\n", ldev->caps.hw_version); > > - if (ldev->panel) { > + if (ldev->bridge) { > encoder = ltdc_rgb_encoder_create(ddev); > if (!encoder) { > DRM_ERROR("Failed to create RGB encoder\n"); > ret = -EINVAL; > goto err; > } You should have a call to drm_bridge_attach() somewhere, otherwise your panel (and its connector) will not be registered. > - > - connector = ltdc_rgb_connector_create(ddev); > - if (!connector) { > - DRM_ERROR("Failed to create RGB connector\n"); > - ret = -EINVAL; > - goto err; > - } > - > - ret = drm_mode_connector_attach_encoder(connector, encoder); > - if (ret) { > - DRM_ERROR("Failed to attach connector to encoder\n"); > - goto err; > - } > - > - drm_panel_attach(ldev->panel, connector); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Date: Fri, 12 May 2017 10:17:46 +0200 Message-ID: <20170512101746.17805ef8@bbrezillon> References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id C1CB06E09D for ; Fri, 12 May 2017 08:17:58 +0000 (UTC) In-Reply-To: <20170511183128.25085-5-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Philippe Cornu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yannick Fertre , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxMSBNYXkgMjAxNyAxMTozMToyNiAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gQW5vdGhlciAxMDAgbGluZXMgb2YgYm9pbGVycGxhdGUgZ29uZS4g IEJyaWRnZXMgYXJlbid0IHN1cHBvcnRlZCB5ZXQsCj4gYnV0IHdpbGwgYmUgdHJpdmlhbCB0byBh ZGQgbGF0ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5l dD4KPiAtLS0KPiAKClsuLi5dCgo+IEBAIC0xMDgyLDI4ICs5OTMsMTMgQEAgaW50IGx0ZGNfbG9h ZChzdHJ1Y3QgZHJtX2RldmljZSAqZGRldikKPiAgCj4gIAlEUk1fSU5GTygibHRkYyBodyB2ZXJz aW9uIDB4JTA4eCAtIHJlYWR5XG4iLCBsZGV2LT5jYXBzLmh3X3ZlcnNpb24pOwo+ICAKPiAtCWlm IChsZGV2LT5wYW5lbCkgewo+ICsJaWYgKGxkZXYtPmJyaWRnZSkgewo+ICAJCWVuY29kZXIgPSBs dGRjX3JnYl9lbmNvZGVyX2NyZWF0ZShkZGV2KTsKPiAgCQlpZiAoIWVuY29kZXIpIHsKPiAgCQkJ RFJNX0VSUk9SKCJGYWlsZWQgdG8gY3JlYXRlIFJHQiBlbmNvZGVyXG4iKTsKPiAgCQkJcmV0ID0g LUVJTlZBTDsKPiAgCQkJZ290byBlcnI7Cj4gIAkJfQoKWW91IHNob3VsZCBoYXZlIGEgY2FsbCB0 byBkcm1fYnJpZGdlX2F0dGFjaCgpIHNvbWV3aGVyZSwgb3RoZXJ3aXNlIHlvdXIKcGFuZWwgKGFu ZCBpdHMgY29ubmVjdG9yKSB3aWxsIG5vdCBiZSByZWdpc3RlcmVkLgoKPiAtCj4gLQkJY29ubmVj dG9yID0gbHRkY19yZ2JfY29ubmVjdG9yX2NyZWF0ZShkZGV2KTsKPiAtCQlpZiAoIWNvbm5lY3Rv cikgewo+IC0JCQlEUk1fRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgUkdCIGNvbm5lY3RvclxuIik7 Cj4gLQkJCXJldCA9IC1FSU5WQUw7Cj4gLQkJCWdvdG8gZXJyOwo+IC0JCX0KPiAtCj4gLQkJcmV0 ID0gZHJtX21vZGVfY29ubmVjdG9yX2F0dGFjaF9lbmNvZGVyKGNvbm5lY3RvciwgZW5jb2Rlcik7 Cj4gLQkJaWYgKHJldCkgewo+IC0JCQlEUk1fRVJST1IoIkZhaWxlZCB0byBhdHRhY2ggY29ubmVj dG9yIHRvIGVuY29kZXJcbiIpOwo+IC0JCQlnb3RvIGVycjsKPiAtCQl9Cj4gLQo+IC0JCWRybV9w YW5lbF9hdHRhY2gobGRldi0+cGFuZWwsIGNvbm5lY3Rvcik7Cj4gIAl9Cj4gIAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==