From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbdEMAAd (ORCPT ); Fri, 12 May 2017 20:00:33 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34537 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755801AbdEMAAb (ORCPT ); Fri, 12 May 2017 20:00:31 -0400 Date: Fri, 12 May 2017 19:00:29 -0500 From: Rob Herring To: Moritz Fischer Cc: linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux@roeck-us.net, wim@iguana.be, alexandre.belloni@free-electrons.com, a.zummo@towertech.it, mark.rutland@arm.com, moritz.fischer@ettus.com Subject: Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Message-ID: <20170513000029.tgzt5p67tcl7uhbx@rob-hp-laptop> References: <1494354021-370-1-git-send-email-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494354021-370-1-git-send-email-mdf@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > This adds a binding for the Maxim/Dallas DS1374 MFD. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I'm not entirely sure aobut the binding, does anyone > have a better suggestion for the remap-wdt-reset property? > > Thanks, > > Moritz > > --- > Documentation/devicetree/bindings/mfd/ds1374.txt | 63 ++++++++++++++++++++++ > .../devicetree/bindings/trivial-devices.txt | 1 - > drivers/rtc/Kconfig | 2 + > 3 files changed, 65 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/mfd/ds1374.txt > > diff --git a/Documentation/devicetree/bindings/mfd/ds1374.txt b/Documentation/devicetree/bindings/mfd/ds1374.txt > new file mode 100644 > index 0000000..b22396f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ds1374.txt > @@ -0,0 +1,63 @@ > +* Device tree bindings for Maxim/Dallas DS1374 Multi Function Device (MFD) > + > +The Maxim/Dallas DS1374 is a multi function device that combines rtc, > +watchdog or alarm, as well as trickle charger. > + > +The DS1374 is connected via I2C. > + > +Required properties: > +- compatible: "dallas,ds1374" > +- reg: I2C slave address > +- dallas,ds1374-mode: Should be one of the following values: Just "dallas,mode" is sufficient. > + <0> for RTC > + <1> for RTC + Alarm (Interrupt) > + <2> for RTC + Watchdog > + > +Required child: > +A single available child device of type matching the "dallas,ds1374-mode" > +property. > + > +Optional properties (watchdog): > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin > + on the device is used as interrupt for > + the alarm Isn't presence of the interrupt property or not enough? It would be kind of useless to have no interrupt and also not do anything on timeout. > + > +See ../watchdog/* for generic watchdog bindings. > + > +Optional properties (real time clock): > +- interrupt: phandle to interrupt cell for the rtc's alarm feature > + > +See ../rtc/* for generic rtc bindings. > + > +Optional properties (trickle-charger): > +- dallas,trickle-resistor-ohms : Selected resistor for trickle charger > + Values usable for ds1374 are 250, 2000, 4000 > + Should be given if trickle charger should be enabled > +- dallas,trickle-diode-disable : Do not use internal trickle charger diode > + Should be given if internal trickle charger diode should be disabled > + > +Example for rtc with alarm mode and interrupt: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + interrupts = <&gpio0 62>; > + dallas,ds1374-mode = <2> > + > + dallas,trickle-resistor-ohms = <250>; > + dallas,trickle-diode-disable; > + }; > +}; > + > +Example for rtc with watchdog and reset on timeout, with reset remapped > +to the INT pin: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + dallas,ds1374-mode = <2> > + dallas,ds1374-remap-wdt-reset; > + }; > +}; > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > index 3e0a34c..f7a50e5 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > @@ -29,7 +29,6 @@ cirrus,cs42l51 Cirrus Logic CS42L51 audio codec > dallas,ds1307 64 x 8, Serial, I2C Real-Time Clock > dallas,ds1338 I2C RTC with 56-Byte NV RAM > dallas,ds1340 I2C RTC with Trickle Charger > -dallas,ds1374 I2C, 32-Bit Binary Counter Watchdog RTC with Trickle Charger and Reset Input/Output > dallas,ds1631 High-Precision Digital Thermometer > dallas,ds1682 Total-Elapsed-Time Recorder with Alarm > dallas,ds1775 Tiny Digital Thermometer and Thermostat > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 8d3b957..e6763fe 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -250,6 +250,8 @@ config RTC_DRV_DS1307_CENTURY > > config RTC_DRV_DS1374 > tristate "Dallas/Maxim DS1374" > + depends on MFD_DS1374 > + depends on REGMAP_I2C > help > If you say yes here you get support for Dallas Semiconductor > DS1374 real-time clock chips. If an interrupt is associated > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com. [209.85.218.66]) by gmr-mx.google.com with ESMTPS id v77si591745ita.0.2017.05.12.17.00.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 May 2017 17:00:30 -0700 (PDT) Received: by mail-oi0-f66.google.com with SMTP id w138so11033917oiw.3 for ; Fri, 12 May 2017 17:00:30 -0700 (PDT) Date: Fri, 12 May 2017 19:00:29 -0500 From: Rob Herring To: Moritz Fischer Cc: linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux@roeck-us.net, wim@iguana.be, alexandre.belloni@free-electrons.com, a.zummo@towertech.it, mark.rutland@arm.com, moritz.fischer@ettus.com Subject: [rtc-linux] Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Message-ID: <20170513000029.tgzt5p67tcl7uhbx@rob-hp-laptop> References: <1494354021-370-1-git-send-email-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" In-Reply-To: <1494354021-370-1-git-send-email-mdf@kernel.org> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > This adds a binding for the Maxim/Dallas DS1374 MFD. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I'm not entirely sure aobut the binding, does anyone > have a better suggestion for the remap-wdt-reset property? > > Thanks, > > Moritz > > --- > Documentation/devicetree/bindings/mfd/ds1374.txt | 63 ++++++++++++++++++++++ > .../devicetree/bindings/trivial-devices.txt | 1 - > drivers/rtc/Kconfig | 2 + > 3 files changed, 65 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/mfd/ds1374.txt > > diff --git a/Documentation/devicetree/bindings/mfd/ds1374.txt b/Documentation/devicetree/bindings/mfd/ds1374.txt > new file mode 100644 > index 0000000..b22396f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ds1374.txt > @@ -0,0 +1,63 @@ > +* Device tree bindings for Maxim/Dallas DS1374 Multi Function Device (MFD) > + > +The Maxim/Dallas DS1374 is a multi function device that combines rtc, > +watchdog or alarm, as well as trickle charger. > + > +The DS1374 is connected via I2C. > + > +Required properties: > +- compatible: "dallas,ds1374" > +- reg: I2C slave address > +- dallas,ds1374-mode: Should be one of the following values: Just "dallas,mode" is sufficient. > + <0> for RTC > + <1> for RTC + Alarm (Interrupt) > + <2> for RTC + Watchdog > + > +Required child: > +A single available child device of type matching the "dallas,ds1374-mode" > +property. > + > +Optional properties (watchdog): > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin > + on the device is used as interrupt for > + the alarm Isn't presence of the interrupt property or not enough? It would be kind of useless to have no interrupt and also not do anything on timeout. > + > +See ../watchdog/* for generic watchdog bindings. > + > +Optional properties (real time clock): > +- interrupt: phandle to interrupt cell for the rtc's alarm feature > + > +See ../rtc/* for generic rtc bindings. > + > +Optional properties (trickle-charger): > +- dallas,trickle-resistor-ohms : Selected resistor for trickle charger > + Values usable for ds1374 are 250, 2000, 4000 > + Should be given if trickle charger should be enabled > +- dallas,trickle-diode-disable : Do not use internal trickle charger diode > + Should be given if internal trickle charger diode should be disabled > + > +Example for rtc with alarm mode and interrupt: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + interrupts = <&gpio0 62>; > + dallas,ds1374-mode = <2> > + > + dallas,trickle-resistor-ohms = <250>; > + dallas,trickle-diode-disable; > + }; > +}; > + > +Example for rtc with watchdog and reset on timeout, with reset remapped > +to the INT pin: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + dallas,ds1374-mode = <2> > + dallas,ds1374-remap-wdt-reset; > + }; > +}; > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > index 3e0a34c..f7a50e5 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > @@ -29,7 +29,6 @@ cirrus,cs42l51 Cirrus Logic CS42L51 audio codec > dallas,ds1307 64 x 8, Serial, I2C Real-Time Clock > dallas,ds1338 I2C RTC with 56-Byte NV RAM > dallas,ds1340 I2C RTC with Trickle Charger > -dallas,ds1374 I2C, 32-Bit Binary Counter Watchdog RTC with Trickle Charger and Reset Input/Output > dallas,ds1631 High-Precision Digital Thermometer > dallas,ds1682 Total-Elapsed-Time Recorder with Alarm > dallas,ds1775 Tiny Digital Thermometer and Thermostat > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 8d3b957..e6763fe 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -250,6 +250,8 @@ config RTC_DRV_DS1307_CENTURY > > config RTC_DRV_DS1374 > tristate "Dallas/Maxim DS1374" > + depends on MFD_DS1374 > + depends on REGMAP_I2C > help > If you say yes here you get support for Dallas Semiconductor > DS1374 real-time clock chips. If an interrupt is associated > -- > 2.7.4 > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Date: Fri, 12 May 2017 19:00:29 -0500 Message-ID: <20170513000029.tgzt5p67tcl7uhbx@rob-hp-laptop> References: <1494354021-370-1-git-send-email-mdf@kernel.org> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1494354021-370-1-git-send-email-mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Moritz Fischer Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > This adds a binding for the Maxim/Dallas DS1374 MFD. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I'm not entirely sure aobut the binding, does anyone > have a better suggestion for the remap-wdt-reset property? > > Thanks, > > Moritz > > --- > Documentation/devicetree/bindings/mfd/ds1374.txt | 63 ++++++++++++++++++++++ > .../devicetree/bindings/trivial-devices.txt | 1 - > drivers/rtc/Kconfig | 2 + > 3 files changed, 65 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/mfd/ds1374.txt > > diff --git a/Documentation/devicetree/bindings/mfd/ds1374.txt b/Documentation/devicetree/bindings/mfd/ds1374.txt > new file mode 100644 > index 0000000..b22396f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ds1374.txt > @@ -0,0 +1,63 @@ > +* Device tree bindings for Maxim/Dallas DS1374 Multi Function Device (MFD) > + > +The Maxim/Dallas DS1374 is a multi function device that combines rtc, > +watchdog or alarm, as well as trickle charger. > + > +The DS1374 is connected via I2C. > + > +Required properties: > +- compatible: "dallas,ds1374" > +- reg: I2C slave address > +- dallas,ds1374-mode: Should be one of the following values: Just "dallas,mode" is sufficient. > + <0> for RTC > + <1> for RTC + Alarm (Interrupt) > + <2> for RTC + Watchdog > + > +Required child: > +A single available child device of type matching the "dallas,ds1374-mode" > +property. > + > +Optional properties (watchdog): > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin > + on the device is used as interrupt for > + the alarm Isn't presence of the interrupt property or not enough? It would be kind of useless to have no interrupt and also not do anything on timeout. > + > +See ../watchdog/* for generic watchdog bindings. > + > +Optional properties (real time clock): > +- interrupt: phandle to interrupt cell for the rtc's alarm feature > + > +See ../rtc/* for generic rtc bindings. > + > +Optional properties (trickle-charger): > +- dallas,trickle-resistor-ohms : Selected resistor for trickle charger > + Values usable for ds1374 are 250, 2000, 4000 > + Should be given if trickle charger should be enabled > +- dallas,trickle-diode-disable : Do not use internal trickle charger diode > + Should be given if internal trickle charger diode should be disabled > + > +Example for rtc with alarm mode and interrupt: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + interrupts = <&gpio0 62>; > + dallas,ds1374-mode = <2> > + > + dallas,trickle-resistor-ohms = <250>; > + dallas,trickle-diode-disable; > + }; > +}; > + > +Example for rtc with watchdog and reset on timeout, with reset remapped > +to the INT pin: > + > +i2c@12ca0000 { > + rtc@68 { > + compatible = "ds1374"; > + reg = <0x68>; > + dallas,ds1374-mode = <2> > + dallas,ds1374-remap-wdt-reset; > + }; > +}; > diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt > index 3e0a34c..f7a50e5 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.txt > +++ b/Documentation/devicetree/bindings/trivial-devices.txt > @@ -29,7 +29,6 @@ cirrus,cs42l51 Cirrus Logic CS42L51 audio codec > dallas,ds1307 64 x 8, Serial, I2C Real-Time Clock > dallas,ds1338 I2C RTC with 56-Byte NV RAM > dallas,ds1340 I2C RTC with Trickle Charger > -dallas,ds1374 I2C, 32-Bit Binary Counter Watchdog RTC with Trickle Charger and Reset Input/Output > dallas,ds1631 High-Precision Digital Thermometer > dallas,ds1682 Total-Elapsed-Time Recorder with Alarm > dallas,ds1775 Tiny Digital Thermometer and Thermostat > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 8d3b957..e6763fe 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -250,6 +250,8 @@ config RTC_DRV_DS1307_CENTURY > > config RTC_DRV_DS1374 > tristate "Dallas/Maxim DS1374" > + depends on MFD_DS1374 > + depends on REGMAP_I2C > help > If you say yes here you get support for Dallas Semiconductor > DS1374 real-time clock chips. If an interrupt is associated > -- > 2.7.4 > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.