From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758399AbdEMAR5 (ORCPT ); Fri, 12 May 2017 20:17:57 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34705 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbdEMARz (ORCPT ); Fri, 12 May 2017 20:17:55 -0400 Date: Fri, 12 May 2017 19:17:53 -0500 From: Rob Herring To: olivier moysan Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, alsa-devel@alsa-project.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com, benjamin.gaignard@st.com Subject: Re: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings Message-ID: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494495904-18898-2-git-send-email-olivier.moysan@st.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: > Add documentation of device tree bindings for STM32 SPI/I2S. > > Signed-off-by: olivier moysan > --- > .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > > diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > new file mode 100644 > index 0000000..67b854a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > @@ -0,0 +1,68 @@ > +STMicroelectronics STM32 SPI/I2S Controller > + > +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. > +Only some SPI instances support I2S. > + > +Required properties: > + - compatible: Must be "st,stm32h7-i2s" > + - reg: Offset and length of the device's register set. > + - interrupts: Must contain the interrupt line id. > + - clocks: Must contain phandle and clock specifier pairs for each entry > + in clock-names. > + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". > + "i2sclk": clock which feeds the internal clock generator > + "pclk": clock which feeds the peripheral bus interface > + "x8k": I2S parent clock for sampling rates multiple of 8kHz. > + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. > + - dmas: DMA specifiers for tx and rx dma. > + See Documentation/devicetree/bindings/dma/stm32-dma.txt. > + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". > + - pinctrl-names: should contain only value "default" > + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt > + > +Optional properties: > + - resets: Reference to a reset controller asserting the reset controller > + > +The device node should contain one 'port' child node with one child 'endpoint' > +node, according to the bindings defined in Documentation/devicetree/bindings/ > +graph.txt. > + > +Example: > +sound_card { > + compatible = "audio-graph-card"; > + dais = <&i2s2_port 0>; What is the 0 representing? > +}; > + > +i2s2: audio-controller@40003800 { > + compatible = "st,stm32h7-i2s"; > + #sound-dai-cells = <0>; Should be dropped. > + reg = <0x40003800 0x400>; > + interrupts = <36>; > + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; > + clock-names = "pclk", "i2sclk", "x8k", "x11k"; > + dmas = <&dmamux2 2 39 0x400 0x1>, > + <&dmamux2 3 40 0x400 0x1>; > + dma-names = "rx", "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s2>; > + > + i2s2_port: port@0 { > + #address-cells = <1>; > + #size-cells = <0>; This shouldn't even compile. You don't need these because because you have no reg property in the endpoint. You have a unit-address here w/o a reg property. You don't need a reg prop because you only have 1 port. > + > + cpu_endpoint: endpoint { > + remote-endpoint = <&codec_endpoint>; > + format = "i2s"; > + bitclock-master = <&codec_endpoint>; > + frame-master = <&codec_endpoint>; > + }; > + }; > +}; > + > +audio-codec { > + codec_port: port@0 { > + codec_endpoint: endpoint { > + remote-endpoint = <&cpu_endpoint>; > + }; > + }; > +}; > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings Date: Fri, 12 May 2017 19:17:53 -0500 Message-ID: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1494495904-18898-2-git-send-email-olivier.moysan-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: olivier moysan Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnaud.pouliquen-qxv4g6HH51o@public.gmane.org, benjamin.gaignard-qxv4g6HH51o@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: > Add documentation of device tree bindings for STM32 SPI/I2S. > > Signed-off-by: olivier moysan > --- > .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > > diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > new file mode 100644 > index 0000000..67b854a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > @@ -0,0 +1,68 @@ > +STMicroelectronics STM32 SPI/I2S Controller > + > +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. > +Only some SPI instances support I2S. > + > +Required properties: > + - compatible: Must be "st,stm32h7-i2s" > + - reg: Offset and length of the device's register set. > + - interrupts: Must contain the interrupt line id. > + - clocks: Must contain phandle and clock specifier pairs for each entry > + in clock-names. > + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". > + "i2sclk": clock which feeds the internal clock generator > + "pclk": clock which feeds the peripheral bus interface > + "x8k": I2S parent clock for sampling rates multiple of 8kHz. > + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. > + - dmas: DMA specifiers for tx and rx dma. > + See Documentation/devicetree/bindings/dma/stm32-dma.txt. > + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". > + - pinctrl-names: should contain only value "default" > + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt > + > +Optional properties: > + - resets: Reference to a reset controller asserting the reset controller > + > +The device node should contain one 'port' child node with one child 'endpoint' > +node, according to the bindings defined in Documentation/devicetree/bindings/ > +graph.txt. > + > +Example: > +sound_card { > + compatible = "audio-graph-card"; > + dais = <&i2s2_port 0>; What is the 0 representing? > +}; > + > +i2s2: audio-controller@40003800 { > + compatible = "st,stm32h7-i2s"; > + #sound-dai-cells = <0>; Should be dropped. > + reg = <0x40003800 0x400>; > + interrupts = <36>; > + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; > + clock-names = "pclk", "i2sclk", "x8k", "x11k"; > + dmas = <&dmamux2 2 39 0x400 0x1>, > + <&dmamux2 3 40 0x400 0x1>; > + dma-names = "rx", "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s2>; > + > + i2s2_port: port@0 { > + #address-cells = <1>; > + #size-cells = <0>; This shouldn't even compile. You don't need these because because you have no reg property in the endpoint. You have a unit-address here w/o a reg property. You don't need a reg prop because you only have 1 port. > + > + cpu_endpoint: endpoint { > + remote-endpoint = <&codec_endpoint>; > + format = "i2s"; > + bitclock-master = <&codec_endpoint>; > + frame-master = <&codec_endpoint>; > + }; > + }; > +}; > + > +audio-codec { > + codec_port: port@0 { > + codec_endpoint: endpoint { > + remote-endpoint = <&cpu_endpoint>; > + }; > + }; > +}; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Fri, 12 May 2017 19:17:53 -0500 Subject: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings In-Reply-To: <1494495904-18898-2-git-send-email-olivier.moysan@st.com> References: <1494495904-18898-1-git-send-email-olivier.moysan@st.com> <1494495904-18898-2-git-send-email-olivier.moysan@st.com> Message-ID: <20170513001753.hygunrcjqejpbwl6@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: > Add documentation of device tree bindings for STM32 SPI/I2S. > > Signed-off-by: olivier moysan > --- > .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > > diff --git a/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > new file mode 100644 > index 0000000..67b854a > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/st,stm32-i2s.txt > @@ -0,0 +1,68 @@ > +STMicroelectronics STM32 SPI/I2S Controller > + > +The SPI/I2S block supports I2S/PCM protocols when configured on I2S mode. > +Only some SPI instances support I2S. > + > +Required properties: > + - compatible: Must be "st,stm32h7-i2s" > + - reg: Offset and length of the device's register set. > + - interrupts: Must contain the interrupt line id. > + - clocks: Must contain phandle and clock specifier pairs for each entry > + in clock-names. > + - clock-names: Must contain "i2sclk", "pclk", "x8k" and "x11k". > + "i2sclk": clock which feeds the internal clock generator > + "pclk": clock which feeds the peripheral bus interface > + "x8k": I2S parent clock for sampling rates multiple of 8kHz. > + "x11k": I2S parent clock for sampling rates multiple of 11.025kHz. > + - dmas: DMA specifiers for tx and rx dma. > + See Documentation/devicetree/bindings/dma/stm32-dma.txt. > + - dma-names: Identifier for each DMA request line. Must be "tx" and "rx". > + - pinctrl-names: should contain only value "default" > + - pinctrl-0: see Documentation/devicetree/bindings/pinctrl/pinctrl-stm32.txt > + > +Optional properties: > + - resets: Reference to a reset controller asserting the reset controller > + > +The device node should contain one 'port' child node with one child 'endpoint' > +node, according to the bindings defined in Documentation/devicetree/bindings/ > +graph.txt. > + > +Example: > +sound_card { > + compatible = "audio-graph-card"; > + dais = <&i2s2_port 0>; What is the 0 representing? > +}; > + > +i2s2: audio-controller at 40003800 { > + compatible = "st,stm32h7-i2s"; > + #sound-dai-cells = <0>; Should be dropped. > + reg = <0x40003800 0x400>; > + interrupts = <36>; > + clocks = <&rcc PCLK1>, <&rcc SPI2_CK>, <&rcc PLL1_Q>, <&rcc PLL2_P>; > + clock-names = "pclk", "i2sclk", "x8k", "x11k"; > + dmas = <&dmamux2 2 39 0x400 0x1>, > + <&dmamux2 3 40 0x400 0x1>; > + dma-names = "rx", "tx"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s2>; > + > + i2s2_port: port at 0 { > + #address-cells = <1>; > + #size-cells = <0>; This shouldn't even compile. You don't need these because because you have no reg property in the endpoint. You have a unit-address here w/o a reg property. You don't need a reg prop because you only have 1 port. > + > + cpu_endpoint: endpoint { > + remote-endpoint = <&codec_endpoint>; > + format = "i2s"; > + bitclock-master = <&codec_endpoint>; > + frame-master = <&codec_endpoint>; > + }; > + }; > +}; > + > +audio-codec { > + codec_port: port at 0 { > + codec_endpoint: endpoint { > + remote-endpoint = <&cpu_endpoint>; > + }; > + }; > +}; > -- > 1.9.1 >