From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git mailing list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] builtin/log: honor log.decorate
Date: Sat, 13 May 2017 02:49:50 +0000 [thread overview]
Message-ID: <20170513024950.qlk5vrdwwsquceyn@genre.crustytoothpaste.net> (raw)
In-Reply-To: <CAMMLpeRkVsvp_fzt+bHSQ_F9gsMhYqej_oyqrjhAXsY1xs7=Qw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On Fri, May 12, 2017 at 07:23:04PM -0600, Alex Henrie wrote:
> When I saw Brian's email today, my first thought was "What was I
> thinking?" My mistake was pretty obvious. Then I remembered that when
> I wrote the original patch, I wasn't sure where to set the default
> value, because there were no clear examples in this file. Now that
> we've established a clear precedent for setting the log.decorate
> default (and other defaults like it) in init_log_defaults, I don't
> expect any more problems with log.decorate. And since it's not
> practical to add tests for similar bugs for every command and
> configuration option in Git, we'll just have to be a little more
> vigilant about code review.
>
> Again, I apologize for the trouble.
Everyone sends a patch that breaks sometimes (I've broken kernel.org's
infrastructure). We try hard to avoid it, but we don't always succeed.
I appreciate your review on my patch and suggestion on how to improve
it, and I hope this won't put you off from further contributions.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2017-05-13 2:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 21:34 [PATCH] builtin/log: honor log.decorate brian m. carlson
2017-05-12 22:03 ` Alex Henrie
2017-05-12 22:07 ` brian m. carlson
2017-05-12 22:12 ` [PATCH v2] " brian m. carlson
2017-05-12 22:22 ` Alex Henrie
2017-05-12 23:32 ` Jonathan Nieder
2017-05-12 23:37 ` brian m. carlson
2017-05-12 23:48 ` Jonathan Nieder
2017-05-13 1:23 ` Alex Henrie
2017-05-13 2:49 ` brian m. carlson [this message]
2017-05-13 2:41 ` brian m. carlson
2017-05-14 18:00 ` [PATCH v3] " brian m. carlson
2017-05-15 2:35 ` Junio C Hamano
2017-05-15 3:48 ` Alex Henrie
2017-05-15 16:26 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170513024950.qlk5vrdwwsquceyn@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.