From: Mark Brown <broonie@kernel.org>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
"# 4 . 10+" <stable@vger.kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH 2/4] ASoC: codecs: msm8916: fix invalid cast to bool type
Date: Sun, 14 May 2017 18:59:45 +0900 [thread overview]
Message-ID: <20170514095945.7oefv6767yiz5nzz@sirena.org.uk> (raw)
In-Reply-To: <20170502133303.19622-3-o-takashi@sakamocchi.jp>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Tue, May 02, 2017 at 10:33:01PM +0900, Takashi Sakamoto wrote:
> This commit fixes this bug by using unsigned int type, instead of bool.
> This bug is detected by sparse:
> smsm8916-wcd-analog.c:809:43: warning: odd constant _Bool cast (40 becomes 1)
> smsm8916-wcd-analog.c:814:43: warning: odd constant _Bool cast (40 becomes 1)
This looks like a bug in sparse - the use of integers in a boolean
context is totally valid and especially the fact that it is claiming
there is a cast when clearly there is no cast is an obvious red flag, at
the very least the message it reports is bogus.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-15 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 13:32 [PATCH 0/4] ALSA/ASoC: fix after merging ASoC PR for v4.12-rc1 Takashi Sakamoto
2017-05-02 13:33 ` [PATCH 1/4] ASoC: codecs: da7213: fix invalid usage of bitwise operation in loop condition Takashi Sakamoto
2017-05-02 14:02 ` Adam Thomson
2017-05-02 13:33 ` [PATCH 2/4] ASoC: codecs: msm8916: fix invalid cast to bool type Takashi Sakamoto
2017-05-14 9:59 ` Mark Brown [this message]
2017-05-15 8:14 ` Takashi Iwai
2017-05-15 8:17 ` Mark Brown
2017-05-15 8:17 ` Mark Brown
2017-05-15 8:43 ` Takashi Iwai
2017-05-15 8:02 ` Applied "ASoC: codecs: msm8916: fix invalid cast to bool type" to the asoc tree Mark Brown
2017-05-02 13:33 ` [PATCH 3/4] ASoC: hisilicon: localize functions without external linkage Takashi Sakamoto
2017-05-15 8:02 ` Applied "ASoC: hisilicon: localize functions without external linkage" to the asoc tree Mark Brown
2017-05-02 13:33 ` [PATCH 4/4] ASoC: intel: atom: localize variable without external linkage Takashi Sakamoto
2017-05-15 8:02 ` Applied "ASoC: intel: atom: localize variable without external linkage" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170514095945.7oefv6767yiz5nzz@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=o-takashi@sakamocchi.jp \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.