From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759749AbdEOGr4 (ORCPT ); Mon, 15 May 2017 02:47:56 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35525 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758953AbdEOGry (ORCPT ); Mon, 15 May 2017 02:47:54 -0400 Date: Mon, 15 May 2017 08:47:49 +0200 From: Daniel Vetter To: Laurent Pinchart Cc: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Alexey Brodkin , Carlos Palminha Subject: Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Message-ID: <20170515064748.25pk2bkdl3q6zg75@phenom.ffwll.local> Mail-Followup-To: Laurent Pinchart , Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexey Brodkin , Carlos Palminha References: <3844793.Y2ncMspPzi@avalon> <65a1928f-a5e8-b668-0925-ff233c21c9fe@synopsys.com> <1874234.uZ7HLpxeJ2@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1874234.uZ7HLpxeJ2@avalon> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 14, 2017 at 02:04:24PM +0300, Laurent Pinchart wrote: > On Friday 12 May 2017 17:06:14 Jose Abreu wrote: > > On 12-05-2017 10:35, Laurent Pinchart wrote: > > > On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: > > >> + if (mode->status == MODE_OK) > > >> + mode->status = drm_mode_validate_connector(connector, > > >> > > >> mode); > > > > > > I would reverse the arguments order to match the style of the other > > > validation functions. > > > > Hmm, I think it makes more sense to pass connector first and then > > mode ... > > I disagree, as this function validates a mode against a pipeline, the same way > the other validation functions validate a mode against other parameters, but > it's your patch :-) Call it drm_connector_validate_mode, because the first argument is generally the object we operate on :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Date: Mon, 15 May 2017 08:47:49 +0200 Message-ID: <20170515064748.25pk2bkdl3q6zg75@phenom.ffwll.local> References: <3844793.Y2ncMspPzi@avalon> <65a1928f-a5e8-b668-0925-ff233c21c9fe@synopsys.com> <1874234.uZ7HLpxeJ2@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBC6E892DC for ; Mon, 15 May 2017 06:47:54 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id d127so25865352wmf.1 for ; Sun, 14 May 2017 23:47:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1874234.uZ7HLpxeJ2@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jose Abreu , Daniel Vetter , Alexey Brodkin , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBNYXkgMTQsIDIwMTcgYXQgMDI6MDQ6MjRQTSArMDMwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBPbiBGcmlkYXkgMTIgTWF5IDIwMTcgMTc6MDY6MTQgSm9zZSBBYnJldSB3cm90 ZToKPiA+IE9uIDEyLTA1LTIwMTcgMTA6MzUsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiA+ IE9uIFR1ZXNkYXkgMDkgTWF5IDIwMTcgMTg6MDA6MTIgSm9zZSBBYnJldSB3cm90ZToKPiA+ID4+ ICsJCWlmIChtb2RlLT5zdGF0dXMgPT0gTU9ERV9PSykKPiA+ID4+ICsJCQltb2RlLT5zdGF0dXMg PSBkcm1fbW9kZV92YWxpZGF0ZV9jb25uZWN0b3IoY29ubmVjdG9yLAo+ID4gPj4gCj4gPiA+PiAg CQkJCQkJCQkgICBtb2RlKTsKPiA+ID4gCj4gPiA+IEkgd291bGQgcmV2ZXJzZSB0aGUgYXJndW1l bnRzIG9yZGVyIHRvIG1hdGNoIHRoZSBzdHlsZSBvZiB0aGUgb3RoZXIKPiA+ID4gdmFsaWRhdGlv biBmdW5jdGlvbnMuCj4gPiAKPiA+IEhtbSwgSSB0aGluayBpdCBtYWtlcyBtb3JlIHNlbnNlIHRv IHBhc3MgY29ubmVjdG9yIGZpcnN0IGFuZCB0aGVuCj4gPiBtb2RlIC4uLgo+IAo+IEkgZGlzYWdy ZWUsIGFzIHRoaXMgZnVuY3Rpb24gdmFsaWRhdGVzIGEgbW9kZSBhZ2FpbnN0IGEgcGlwZWxpbmUs IHRoZSBzYW1lIHdheSAKPiB0aGUgb3RoZXIgdmFsaWRhdGlvbiBmdW5jdGlvbnMgdmFsaWRhdGUg YSBtb2RlIGFnYWluc3Qgb3RoZXIgcGFyYW1ldGVycywgYnV0IAo+IGl0J3MgeW91ciBwYXRjaCA6 LSkKCkNhbGwgaXQgZHJtX2Nvbm5lY3Rvcl92YWxpZGF0ZV9tb2RlLCBiZWNhdXNlIHRoZSBmaXJz dCBhcmd1bWVudCBpcwpnZW5lcmFsbHkgdGhlIG9iamVjdCB3ZSBvcGVyYXRlIG9uIDotKQotRGFu aWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK