All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Steven Miao <realmz6@gmail.com>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.co.uk>,
	linux-gpio@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: [PATCHv3 14/14] pinctrl: mcp23s08: fix comment for mcp23s08_platform_data.base
Date: Mon, 15 May 2017 11:24:38 +0200	[thread overview]
Message-ID: <20170515092438.13076-15-sebastian.reichel@collabora.co.uk> (raw)
In-Reply-To: <20170515092438.13076-1-sebastian.reichel@collabora.co.uk>

The comment does not match the driver, which actually supports
automatic assignment. Fix this by updating the comment.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 include/linux/spi/mcp23s08.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/spi/mcp23s08.h b/include/linux/spi/mcp23s08.h
index 4354beefd584..82d96a346e6f 100644
--- a/include/linux/spi/mcp23s08.h
+++ b/include/linux/spi/mcp23s08.h
@@ -7,11 +7,11 @@ struct mcp23s08_platform_data {
 	 */
 	u32 spi_present_mask;
 
-	/* "base" is the number of the first GPIO.  Dynamic assignment is
-	 * not currently supported, and even if there are gaps in chip
-	 * addressing the GPIO numbers are sequential .. so for example
-	 * if only slaves 0 and 3 are present, their GPIOs range from
-	 * base to base+15 (or base+31 for s17 variant).
+	/* "base" is the number of the first GPIO or -1 for dynamic
+	 * assignment. If there are gaps in chip addressing the GPIO
+	 * numbers are sequential .. so for example if only slaves 0
+	 * and 3 are present, their GPIOs range from base to base+15
+	 * (or base+31 for s17 variant).
 	 */
 	unsigned	base;
 };
-- 
2.11.0


  parent reply	other threads:[~2017-05-15  9:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15  9:24 [PATCHv3 00/14] mcp23s08 pinconf & cleanup Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 01/14] gpio: mcp23s08: move to pinctrl Sebastian Reichel
2017-05-16 19:45   ` Sylvain Lemieux
2017-05-15  9:24 ` [PATCHv3 02/14] pinctrl: mcp23s08: add pinconf support Sebastian Reichel
2017-05-15 12:34   ` Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 03/14] pinctrl: mcp23s08: drop pullup config from pdata Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 04/14] pinctrl: mcp23s08: switch to regmap caching Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 05/14] pinctrl: mcp23s08: drop OF_GPIO dependency Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 06/14] pinctrl: mcp23s08: irq mapping is already done Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 07/14] pinctrl: mcp23s08: use managed kzalloc for mcp Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 08/14] pinctrl: mcp23s08: switch to devm_gpiochip_add_data Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 09/14] pinctrl: mcp23s08: simplify i2c pdata handling Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 10/14] pinctrl: mcp23s08: simplify spi " Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 11/14] pinctrl: mcp23s08: generalize irq property handling Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 12/14] pinctrl: mcp23s08: simplify spi_present_mask handling Sebastian Reichel
2017-05-15  9:24 ` [PATCHv3 13/14] pinctrl: mcp23s08: drop comment about missing irq support Sebastian Reichel
2017-05-15  9:24 ` Sebastian Reichel [this message]
2017-05-23  7:55 ` [PATCHv3 00/14] mcp23s08 pinconf & cleanup Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515092438.13076-15-sebastian.reichel@collabora.co.uk \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=enric.balletbo@collabora.co.uk \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=realmz6@gmail.com \
    --cc=slemieux.tyco@gmail.com \
    --cc=sre@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.