From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760523AbdEOJdB (ORCPT ); Mon, 15 May 2017 05:33:01 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44264 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759276AbdEOJc7 (ORCPT ); Mon, 15 May 2017 05:32:59 -0400 Date: Mon, 15 May 2017 11:32:57 +0200 From: Alexandre Belloni To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Wolfram Sang , devicetree@vger.kernel.org, Russell King , Rob Herring , Nicolas Ferre , Peter Rosin , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 05/21] ARM: dts: at91: Add generic compatible string for I2C EEPROM Message-ID: <20170515093257.ge67swobfgi76nou@piout.net> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-6-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414010445.21727-6-javier@osg.samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2017 at 22:04:29 -0300, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Peter Rosin > > --- > > Changes in v3: > - Add Peter Rosin acked-by tag. > > Changes in v2: None > > arch/arm/boot/dts/at91-linea.dtsi | 2 +- > arch/arm/boot/dts/at91-tse850-3.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v3 05/21] ARM: dts: at91: Add generic compatible string for I2C EEPROM Date: Mon, 15 May 2017 11:32:57 +0200 Message-ID: <20170515093257.ge67swobfgi76nou@piout.net> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-6-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170414010445.21727-6-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wolfram Sang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Rob Herring , Nicolas Ferre , Peter Rosin , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 13/04/2017 at 22:04:29 -0300, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Peter Rosin > > --- > > Changes in v3: > - Add Peter Rosin acked-by tag. > > Changes in v2: None > > arch/arm/boot/dts/at91-linea.dtsi | 2 +- > arch/arm/boot/dts/at91-tse850-3.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 15 May 2017 11:32:57 +0200 Subject: [PATCH v3 05/21] ARM: dts: at91: Add generic compatible string for I2C EEPROM In-Reply-To: <20170414010445.21727-6-javier@osg.samsung.com> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-6-javier@osg.samsung.com> Message-ID: <20170515093257.ge67swobfgi76nou@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13/04/2017 at 22:04:29 -0300, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Peter Rosin > > --- > > Changes in v3: > - Add Peter Rosin acked-by tag. > > Changes in v2: None > > arch/arm/boot/dts/at91-linea.dtsi | 2 +- > arch/arm/boot/dts/at91-tse850-3.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com