From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935291AbdEOSX2 (ORCPT ); Mon, 15 May 2017 14:23:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933172AbdEOSX0 (ORCPT ); Mon, 15 May 2017 14:23:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AEACA368E4 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AEACA368E4 From: Hans de Goede To: Lee Jones Cc: Hans de Goede , linux-kernel@vger.kernel.org Subject: [PATCH v4 2/2] mfd: axp20x-i2c: Document that this must be builtin on x86 Date: Mon, 15 May 2017 20:23:22 +0200 Message-Id: <20170515182322.7583-2-hdegoede@redhat.com> In-Reply-To: <20170515182322.7583-1-hdegoede@redhat.com> References: <20170515182322.7583-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 15 May 2017 18:23:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if the mfd, OpRegionr and i2c-bus drivers are built in. Since the axp20x mfd code is used on non X86 too we cannot simply change this into a bool, I've tried some Kconfig magic with if x86 but I could not get this working correctly, so this commit just documents that this should be builtin on x86, which fixes errors like these during boot: mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b acpi 80860F14:02: Failed to change power state to D0 Signed-off-by: Hans de Goede --- Changes in v2: -Fix Kconfig depends and selects to fix warning reported by kbuild test robot -Improve commit msg (add example of ACPI errors this avoids) Changes in v3: -Since the axp20x mfd code is used on ARM too where it does not necessarily need to be builtin settle for simply documenting the need to have this builtin on x86 --- drivers/mfd/Kconfig | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 61ebda81e134..cfac1e8a0a20 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -160,6 +160,11 @@ config MFD_AXP20X_I2C components like regulators or the PEK (Power Enable Key) under the corresponding menus. + Note on x86 this provides an ACPI OpRegion, so this must be 'y' + (builtin) and not a module, as the OpRegion must be available as + soon as possible. For the same reason the i2c bus driver options + I2C_DESIGNWARE_PLATFORM and I2C_DESIGNWARE_BAYTRAIL must be 'y' too. + config MFD_AXP20X_RSB tristate "X-Powers AXP series PMICs with RSB" select MFD_AXP20X -- 2.12.2