All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] kbuild: update DTC warning settings for bus and node/property name checks
@ 2017-05-15  7:07 Masahiro Yamada
  2017-05-15 23:20 ` [U-Boot] " Tom Rini
  2017-05-16  0:17 ` [U-Boot] [PATCH] " Simon Glass
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-05-15  7:07 UTC (permalink / raw)
  To: u-boot

Recent commits of DTC introduced new warnings checking PCI and simple
buses, unit address formatting, and stricter node and property name
checking.  Disable the new DTC warnings by default.  As before,
warnings are enabled with W=*.  The strict node and property name
checks are a bit subjective, so they are only enabled for W=2.
(This policy reflects the commit 8654cb8d0371 of Linux.)

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 scripts/Makefile.extrawarn | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 7b2cffc..90dc149 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -58,9 +58,23 @@ endif
 
 KBUILD_CFLAGS += $(warning)
 
+dtc-warning-2 += $(call dtc-option,-Wnode_name_chars_strict)
+dtc-warning-2 += $(call dtc-option,-Wproperty_name_chars_strict)
+
+dtc-warning := $(dtc-warning-$(findstring 1, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+dtc-warning += $(dtc-warning-$(findstring 2, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+dtc-warning += $(dtc-warning-$(findstring 3, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+
+DTC_FLAGS += $(dtc-warning)
+
 else
 
 # Disable noisy checks by default
 DTC_FLAGS += $(call dtc-option,-Wno-unit_address_vs_reg)
+DTC_FLAGS += $(call dtc-option,-Wno-simple_bus_reg)
+DTC_FLAGS += $(call dtc-option,-Wno-unit_address_format)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_bridge)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_device_bus_num)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_device_reg)
 
 endif
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] kbuild: update DTC warning settings for bus and node/property name checks
  2017-05-15  7:07 [U-Boot] [PATCH] kbuild: update DTC warning settings for bus and node/property name checks Masahiro Yamada
@ 2017-05-15 23:20 ` Tom Rini
  2017-05-16  0:17 ` [U-Boot] [PATCH] " Simon Glass
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-05-15 23:20 UTC (permalink / raw)
  To: u-boot

On Mon, May 15, 2017 at 04:07:33PM +0900, Masahiro Yamada wrote:

> Recent commits of DTC introduced new warnings checking PCI and simple
> buses, unit address formatting, and stricter node and property name
> checking.  Disable the new DTC warnings by default.  As before,
> warnings are enabled with W=*.  The strict node and property name
> checks are a bit subjective, so they are only enabled for W=2.
> (This policy reflects the commit 8654cb8d0371 of Linux.)
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170515/23f632e3/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] kbuild: update DTC warning settings for bus and node/property name checks
  2017-05-15  7:07 [U-Boot] [PATCH] kbuild: update DTC warning settings for bus and node/property name checks Masahiro Yamada
  2017-05-15 23:20 ` [U-Boot] " Tom Rini
@ 2017-05-16  0:17 ` Simon Glass
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2017-05-16  0:17 UTC (permalink / raw)
  To: u-boot

On 15 May 2017 at 01:07, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Recent commits of DTC introduced new warnings checking PCI and simple
> buses, unit address formatting, and stricter node and property name
> checking.  Disable the new DTC warnings by default.  As before,
> warnings are enabled with W=*.  The strict node and property name
> checks are a bit subjective, so they are only enabled for W=2.
> (This policy reflects the commit 8654cb8d0371 of Linux.)
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  scripts/Makefile.extrawarn | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-16  0:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-15  7:07 [U-Boot] [PATCH] kbuild: update DTC warning settings for bus and node/property name checks Masahiro Yamada
2017-05-15 23:20 ` [U-Boot] " Tom Rini
2017-05-16  0:17 ` [U-Boot] [PATCH] " Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.