From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: [PATCH v2 2/4] drm/i915: introduce vgt_caps to pvinfo Date: Tue, 16 May 2017 09:16:39 +0800 Message-ID: <20170516011639.34a2s677kwcpunyo@zhen-hp.sh.intel.com> References: <1494581878-2258-1-git-send-email-tina.zhang@intel.com> <1494581878-2258-3-git-send-email-tina.zhang@intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0703118644==" Return-path: In-Reply-To: <1494581878-2258-3-git-send-email-tina.zhang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tina Zhang Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0703118644== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wh5qjvjekzgmege4" Content-Disposition: inline --wh5qjvjekzgmege4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017.05.12 17:37:56 +0800, Tina Zhang wrote: > vgt_caps is used for guest i915 driver to get the vgpu capabilities from > the device model. VGT_CPAS_FULL_PPGTT is one of the capabilities type to > let guest i915 dirver know that the guest i915 full ppgtt is supported by > device model. >=20 > Changes since v1: > - Use u32 instead of uint32_t (Joonas) > - Move VGT_CAPS_FULL_PPGTT introduction to this patch and use #define ins= tead > of enum (Joonas) >=20 > Signed-off-by: Tina Zhang > --- > drivers/gpu/drm/i915/i915_pvinfo.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_pvinfo.h b/drivers/gpu/drm/i915/i9= 15_pvinfo.h > index c0cb297..8dc0664 100644 > --- a/drivers/gpu/drm/i915/i915_pvinfo.h > +++ b/drivers/gpu/drm/i915/i915_pvinfo.h > @@ -53,12 +53,18 @@ enum vgt_g2v_type { > VGT_G2V_MAX, > }; > =20 > +/* > + * VGT capabilities type > + */ > +#define VGT_CAPS_FULL_PPGTT BIT(2) > + > struct vgt_if { > u64 magic; /* VGT_MAGIC */ > uint16_t version_major; > uint16_t version_minor; > u32 vgt_id; /* ID of vGT instance */ > - u32 rsv1[12]; /* pad to offset 0x40 */ > + u32 vgt_caps; /* VGT capabilities */ > + u32 rsv1[11]; /* pad to offset 0x40 */ We need to bump pvinfo version for this structural change to keep versioned pvinfo page for compat check. So in this case I sugguest to bump minor vers= ion and check required pvinfo version when detecting caps. > /* > * Data structure to describe the balooning info of resources. > * Each VM can only have one portion of continuous area for now. > --=20 > 2.7.4 >=20 > _______________________________________________ > intel-gvt-dev mailing list > intel-gvt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --wh5qjvjekzgmege4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCWRpS9wAKCRCxBBozTXgY J8nnAJ9t+JMICzKRN+Eu/J2IMG8UW4U8ywCfW2QvKBaQz+6kNEUi8yL1Br+4C8o= =ilAn -----END PGP SIGNATURE----- --wh5qjvjekzgmege4-- --===============0703118644== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0703118644==--