From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, lee.jones@linaro.org,
devicetree@vger.kernel.org, linux@roeck-us.net, wim@iguana.be,
a.zummo@towertech.it, mark.rutland@arm.com
Subject: Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding
Date: Tue, 16 May 2017 10:16:38 +0200 [thread overview]
Message-ID: <20170516081638.xg34g52xpvlkpqfg@piout.net> (raw)
In-Reply-To: <20170516023417.GA28179@tyrael.amer.corp.natinst.com>
On 15/05/2017 at 19:34:17 -0700, Moritz Fischer wrote:
> On Fri, May 12, 2017 at 07:00:29PM -0500, Rob Herring wrote:
> > On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote:
> > > + <0> for RTC
> > > + <1> for RTC + Alarm (Interrupt)
> > > + <2> for RTC + Watchdog
> > > +
> > > +Required child:
> > > +A single available child device of type matching the "dallas,ds1374-mode"
> > > +property.
> > > +
> > > +Optional properties (watchdog):
> > > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin
> > > + on the device is used as interrupt for
> > > + the alarm
> >
> > Isn't presence of the interrupt property or not enough? It would be
> > kind of useless to have no interrupt and also not do anything on
> > timeout.
>
> So you're saying:
>
> If interrupt not present AND mode = <0> ignore interrupt
>
> If interrupt present AND mode = <1> (maybe define here would be nicer),
> make it an interrupt.
>
If mode == 1, WDSTR doesn't matter so it will always be on the INT pin
anyway.
> If interrupt not present AND mode = <2> then this implies that reset
> output is mapped to RST pin.
>
> If Interrupt present AND mode = <2> then this implies that the reset
> output is (re)mapped to INT pin?
>
Yes, I think this is sufficient.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-05-16 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 18:20 [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Moritz Fischer
2017-05-09 18:20 ` [RFC/PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device Moritz Fischer
2017-05-09 18:20 ` Moritz Fischer
2017-05-09 23:48 ` Moritz Fischer
2017-05-09 23:48 ` Moritz Fischer
2017-05-13 0:00 ` [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding Rob Herring
2017-05-13 0:00 ` Rob Herring
2017-05-13 0:00 ` [rtc-linux] " Rob Herring
2017-05-16 2:34 ` Moritz Fischer
2017-05-16 2:34 ` Moritz Fischer
2017-05-16 8:16 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516081638.xg34g52xpvlkpqfg@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.