From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH nf v2] ebtables: arpreply: Add the standard target sanity check Date: Tue, 16 May 2017 10:24:00 +0200 Message-ID: <20170516082400.GA11114@salvia> References: <1494898218-97426-1-git-send-email-gfree.wind@vip.163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: stephen@networkplumber.org, fw@strlen.de, netfilter-devel@vger.kernel.org To: gfree.wind@vip.163.com Return-path: Received: from ganesha.gnumonks.org ([213.95.27.120]:60830 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbdEPIYI (ORCPT ); Tue, 16 May 2017 04:24:08 -0400 Content-Disposition: inline In-Reply-To: <1494898218-97426-1-git-send-email-gfree.wind@vip.163.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Tue, May 16, 2017 at 09:30:18AM +0800, gfree.wind@vip.163.com wrote: > From: Gao Feng > > The info->target is from userspace and it would be used directly. > So we need to add the sanity check to make sure it is a valid standard > target, although the ebtables tool has already checked it. Kernel need > to check anything from userspace. > > If the target was set as an evil value, it would break the ebtables > and cause a panic. Because the non-standard target is treated as one > offset. > > Now add one helper function ebt_invalid_target, and we would replace > the macro INVALID_TARGET later. Applied, thanks. There is a few bunch of spots that can use this indeed. Follow up with a patch for nf-next once merge window opens up.