From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdEPJaG (ORCPT ); Tue, 16 May 2017 05:30:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:55541 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751137AbdEPJaB (ORCPT ); Tue, 16 May 2017 05:30:01 -0400 Date: Tue, 16 May 2017 11:29:56 +0200 From: Michal Hocko To: Roman Gushchin Cc: Johannes Weiner , Tejun Heo , Li Zefan , Vladimir Davydov , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Message-ID: <20170516092956.GF2481@dhcp22.suse.cz> References: <1494530183-30808-1-git-send-email-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494530183-30808-1-git-send-email-guro@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 11-05-17 20:16:23, Roman Gushchin wrote: > Track the following reclaim counters for every memory cgroup: > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > PGLAZYFREED. yes, those are definitely useful. I have an old patch to add them as well but never managed to clean it up and post... > These values are exposed using the memory.stats interface of cgroup v2. Is there any reason to not add them to v1? This should be rather trivial after recent changes from Johannes. > The meaning of each value is the same as for global counters, > available using /proc/vmstat. > > Also, for consistency, rename mem_cgroup_count_vm_event() to > count_memcg_event_mm(). > > Signed-off-by: Roman Gushchin > Suggested-by: Johannes Weiner > Cc: Johannes Weiner > Cc: Tejun Heo > Cc: Li Zefan > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: cgroups@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org the patch itself looks good to me. I will have to double check it after I am done with what I am doing currently and then will add my Acked-by -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 1D8A56B03A5 for ; Tue, 16 May 2017 05:30:02 -0400 (EDT) Received: by mail-pf0-f198.google.com with SMTP id y65so121211275pff.13 for ; Tue, 16 May 2017 02:30:02 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id p2si10380354pfg.78.2017.05.16.02.30.01 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 16 May 2017 02:30:01 -0700 (PDT) Date: Tue, 16 May 2017 11:29:56 +0200 From: Michal Hocko Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Message-ID: <20170516092956.GF2481@dhcp22.suse.cz> References: <1494530183-30808-1-git-send-email-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494530183-30808-1-git-send-email-guro@fb.com> Sender: owner-linux-mm@kvack.org List-ID: To: Roman Gushchin Cc: Johannes Weiner , Tejun Heo , Li Zefan , Vladimir Davydov , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu 11-05-17 20:16:23, Roman Gushchin wrote: > Track the following reclaim counters for every memory cgroup: > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > PGLAZYFREED. yes, those are definitely useful. I have an old patch to add them as well but never managed to clean it up and post... > These values are exposed using the memory.stats interface of cgroup v2. Is there any reason to not add them to v1? This should be rather trivial after recent changes from Johannes. > The meaning of each value is the same as for global counters, > available using /proc/vmstat. > > Also, for consistency, rename mem_cgroup_count_vm_event() to > count_memcg_event_mm(). > > Signed-off-by: Roman Gushchin > Suggested-by: Johannes Weiner > Cc: Johannes Weiner > Cc: Tejun Heo > Cc: Li Zefan > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: cgroups@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org the patch itself looks good to me. I will have to double check it after I am done with what I am doing currently and then will add my Acked-by -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Date: Tue, 16 May 2017 11:29:56 +0200 Message-ID: <20170516092956.GF2481@dhcp22.suse.cz> References: <1494530183-30808-1-git-send-email-guro@fb.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1494530183-30808-1-git-send-email-guro-b10kYP2dOMg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Gushchin Cc: Johannes Weiner , Tejun Heo , Li Zefan , Vladimir Davydov , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Thu 11-05-17 20:16:23, Roman Gushchin wrote: > Track the following reclaim counters for every memory cgroup: > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > PGLAZYFREED. yes, those are definitely useful. I have an old patch to add them as well but never managed to clean it up and post... > These values are exposed using the memory.stats interface of cgroup v2. Is there any reason to not add them to v1? This should be rather trivial after recent changes from Johannes. > The meaning of each value is the same as for global counters, > available using /proc/vmstat. > > Also, for consistency, rename mem_cgroup_count_vm_event() to > count_memcg_event_mm(). > > Signed-off-by: Roman Gushchin > Suggested-by: Johannes Weiner > Cc: Johannes Weiner > Cc: Tejun Heo > Cc: Li Zefan > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org the patch itself looks good to me. I will have to double check it after I am done with what I am doing currently and then will add my Acked-by -- Michal Hocko SUSE Labs