From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbdEPNOb (ORCPT ); Tue, 16 May 2017 09:14:31 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44423 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750970AbdEPNO1 (ORCPT ); Tue, 16 May 2017 09:14:27 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=fb.com; Date: Tue, 16 May 2017 14:13:16 +0100 From: Roman Gushchin To: Michal Hocko CC: Johannes Weiner , Tejun Heo , Li Zefan , Vladimir Davydov , , , , Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Message-ID: <20170516131316.GA7834@castle> References: <1494530183-30808-1-git-send-email-guro@fb.com> <20170516092956.GF2481@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170516092956.GF2481@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [2620:10d:c092:200::1:f32a] X-ClientProxiedBy: VI1PR0401CA0009.eurprd04.prod.outlook.com (10.168.59.19) To SN2PR15MB1088.namprd15.prod.outlook.com (10.169.192.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75d02924-ca05-4695-1f5d-08d49c5d5b15 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:SN2PR15MB1088; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1088;3:S2mwLW/hJ1Rf6PFejl78ojv4QbhK1GSfItYBh3++yAA39aaGOfC+nQ85M7OipN/eBwNa/jzdd3e0rJXHDuI7Pbb0QFvX3BVSLot0SsBnRIzwEcm9ZHXVr2WBLNMLyFbVwX3BPlN1QLyBDpmFaXWdXEUETFu/v/UDrgz8vfHvVFmcYjSwO4XIbi1rHy44oj6FcB7kDAIgNlJH+w8XPpuXDkKYUJNJ0aCg2g3yZpg1DobkpU76TEVObChFjdaIQGDniAZUdctUwcXGPoylNp27044pzKlys0/ihLPApQsAEUhiGC+XNKACPNhsoieX8uwlZDNfb/08TiKsLPqMUzRiSg==;25:1bSsG9EAANlFlG80CGcfSE9cFZCgVhaUFEkjEEdy7WH4M4+vAcmnsYB6iJSY7txcv1XlrVED+qfDAkocdwun/GvfrvUMh10QETSZ77eoYi+w6FLq302kOOCXldfs2Iq7Yfdg1wVMJYK1v1FYVpzIcgdJ4yXIwlx9DlMUGn1Fw+jtWlvOEb7mkyt91A7B+v4kVUWIRbOntJWV2b/mION8mSkPrpdK8WvhSEcWfKbJraqyahjnJqghhYq+WONG/s4VmiHHWoBUBJx+YM44WPMsXhQL7tyGGxu0pJbm4qkAQkhpR8rykUdlgjgE0/kfDk6dvMmTgpU9DlTM2G+BH3vgUnaBSUIMqOhiyhS6fOnd3eERq44EdYfSWAW3k8g5a+dgiY6xvgND/SWulezdh2vjuy7XNSKamaZHuZffKiAz2A7Hfeb5D5131cDrb598WmPkOxn2+NTBRDARq/TJNCbwz6X5aVGfb9rH6y4/atHv0MY= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1088;31:DHGLvREb1z8qtXTKhUMfQ2sy1xKBGdrwuz8rhIm9DMYxQ19VM4i7o6J+oRDNYhzgvwxDpZjhHL7FqCeNgx5/5UJ81zQOz7WPjO/0Zl16aj1M6/0VFm2UfYSadjVuoYb+m7Q8+b/4gXstnq1n9Nj3pQgxfe5ac9bjLWbmsFtkrqUYayNQuFhzOYnZkIGLolxggxYfTh4Y137rP1+jciXP6Ohj8CrIRVbcF3VtJxw5UzZ1STQ1hbSo5NgS/+DR1mAbygaNH32h0XjnFzFCtx778Q==;20:ztG/mLtrqT3au/dOtbYfPqA7pOr9EkyD+BcnnXAJYWAqDHasB+dwQe9gAbqKgkXGTFotuxVAx7FGwzGCtbqooBguBvpWv3uwZ4DfpqmLkGnTFpmEBzBqejFzZw7RlqywmccfigVuHqEC9fwcCRTmCxun3CCq8Lomv280HDsOwvlPTkP4quWRL0eDXH7f36JvU4jMyabeTI0gbRN+91NjN+SWNo6ijHtQb4GmKCmpquOeyVH8GBOeFr1rlV/PUEk7oiuBrWyuE41X3QM1JPPnfIXBTG4U+BAQRSLPECRyHmhOrthFX1L0WE4PF1gJyyl3hC5c2apadFfpKgzUmWNGxlgEfJWvPeA2EEHZ05hQ22PJrnYowV1ZVzubXHtR181pg/4L3dmdT4e7PnWNjBYdldsIkSKYf+tDrGlVKJ8OWp8dP2CMHYfGiVDPjr/stQUw2OGpdOTaA7UMpyX2Cuj6baY/B2jvbhbJHxOtQOh0HNJ2iK5wwcC/Cg44AR3SBIg6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(50582790962513)(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148);SRVR:SN2PR15MB1088;BCL:0;PCL:0;RULEID:;SRVR:SN2PR15MB1088; X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1088;4:5rjYlg38v3zB0TBymNQRlcXwsmEGY0Tf02siQ2sEmsD0qAUBe/a4tR7LcbzB9MleYll3HAuk09kT7/q2ucN9IQzbAJdynM16cLW7K7RqRMn/YifSvuruAoY0DMDUI2xN796GjmqmuJCKKo1AVRMW23YZF4j8eI41bKf+c+mu2ni5CF6QjotuOosoQFBOauawRELfnYjBPdWSv5/q1H8KDoAA3Ti9LUqxg04WCWDU993wbypCsqdDUHhXZnk1hjfs9mXO++aK/adVgUoWnQ/iDhEITbezFEKLkJg8BDEvzbdITnA8qRP4+7Cpgd5loAsoROo0R8F7rSKaPQNZRjYx7dWpce012utv80KSCTDNrixsrVWcb72ciUvVYp/dF6b2FRvOvSET8smCTp4iVvMc81S7kmecsW6dLkfXnFMxEhl/3coBZ66s6OlFnsEtmvmJcpnz6zO/Z2uhy81ixJ1VlVbOwmUUuHv73hVNkiagJ312EmJ/St3eEvNN0s0snuVosLgwwOoN7exHCJl7N1bqcuXktX2Xekh+nekvbQVV4WN5WFysq/NlVLtu6Wxg6sUelM0ZKFOzyiX4yMkf/9y6soa073nYgZ6dIiljPCxFOJrj0WPiY5M+p4soN70jCSOLwvXgO9sJWnlu76P/xWtZGZcZf6q+z86wtldZrjyB9X6TqUMOXEw/TREeNaU09YIC2AsK2/Htnwrvoo8fR9Cezl2FY87APbV/tHGeBv2qVa7mA5dZTlC7X2HOn6JFyIZ4iEwpw+z2nm2w+Yg+waYKZFrT8y9N1XOACtZYQ1Zukkpy6zVgfy1HaFPOc0TCp70SkMV3BK6GzLKYp/WNOoGhVegMp+p/7O+DNdcni/3aBQVdrqd2QQD9MX58xFNhwWGFeKUH2IBRPfzySqDCJ8VHlA== X-Forefront-PRVS: 03094A4065 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39850400002)(39400400002)(39840400002)(39410400002)(39450400003)(24454002)(377424004)(6246003)(110136004)(53936002)(478600001)(38730400002)(305945005)(6496005)(7736002)(50986999)(76176999)(33716001)(50466002)(2906002)(54356999)(1076002)(23726003)(6116002)(33656002)(47776003)(42186005)(6916009)(55016002)(229853002)(46406003)(9686003)(54906002)(6666003)(5660300001)(2950100002)(81166006)(86362001)(97756001)(8676002)(25786009)(4326008)(189998001)(4001350100001)(83506001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN2PR15MB1088;H:castle;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR15MB1088;23:S3WDFz5jbc8NCVVtE5/K7d8ead9WNQCPD2A//h72l?= =?us-ascii?Q?yeNn5k0vpZ45iTOR1n+vAAOeo50IIsh3D1ioHMkHVDwIn2UrogqtMmNCApZk?= =?us-ascii?Q?x9LD/Ey5ISqY2KR+tIvAbJyIuUdcV1yGmcT+YYxNvXcN26r6b87/QhYV9KJn?= =?us-ascii?Q?aoiNRELU6JrlUE6g4vcb0bER+70LlfJln5KxWuaNFWHDiOnGof01sTs1oIOc?= =?us-ascii?Q?SdEVeY+vzdXnlrczf1DVndf1YG/hnbceKNoeuHHx6Vvnws11IiG4t3G1jrYV?= =?us-ascii?Q?kNYYw3KtMJZtHgwxEYtuj3a4IXf/uc24r7DhigeR2R2si+XEGQyloM3setTZ?= =?us-ascii?Q?ODluVsnGPCN27AuFvSa+zuWmLkjYoXdLI5NhY2GIbcoirYW06Vih+Bs0FIOP?= =?us-ascii?Q?0h3q/rRrzzUHUA19bPLm5MgjYrLKnhvjwBANgNSyQcGBVKNlk74cE8VjQKfb?= =?us-ascii?Q?j1YA0EEkA27+U50zRzbadqXkBsirWOe8cU5L+NVyz4/HHShiK4bCxNFlOiPp?= =?us-ascii?Q?vTya0ECgU3Yl9glGTpY7545iMzebtSrPqPeaVjNT0dEngpnItqIZixf2Gy+A?= =?us-ascii?Q?mBkvwgr57AXZjj4Ekql1gRvaBywS38eo0rAzShTHtmjvKrVyrON8Feb7FVea?= =?us-ascii?Q?SL7skdL7GYoSTcbmIO8UB/RVpDa3xD0IJbcYTt0J8bnKXkPIbZ3DSRpfmrIg?= =?us-ascii?Q?QG17Z8udWJXIPtKwU+AaUE1RjVMZhFYBcG3CIZJWPYSMHadJppzYLeKQHGRc?= =?us-ascii?Q?OLdIZZGojPwsWGTx6D58G2HGrPAB5TkYXO25F4l14Kii1/k2eOtVnyeY//Cy?= =?us-ascii?Q?RRkNOoGPSqgGf1aVp2HzVrEEl2+D5O7eu5hjDK/1duZlJivhWoVzXapvAJi6?= =?us-ascii?Q?GrMtyqAJ0IphTE1/WDlpYrc12I/ThQplJwcbM5umGbmlp9J5jkRYlrAhAxNM?= =?us-ascii?Q?ckLlH9qaElLD8RT5IbcrEHwuhFeDo96oFPzkp5V+v/Px95XaNFKZvp0UGEQU?= =?us-ascii?Q?CuQIpOCCwfQK9lBWd2Op+VUtS+KJlFjIrVEKTGC23pGxYRyBsO/4EaWJPnPY?= =?us-ascii?Q?Rkp8YaP/x977wn8OCa9z914VR2xGS9kyoAl7525/qNS71rS1q5DMnDqCE9Lk?= =?us-ascii?Q?LZ06FmwRFlwroopssmE8AU7FkSmSQhzMVLRHvIKC964m4luVCYr+Prqimmak?= =?us-ascii?Q?cX0R090v1JWc2skdg1/5k1xNtbYAjaWWEMFUln09Y5qkbPJQLVgdwwJ/g=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1088;6:33nniMysSV3xF5ufdivLeiBu1DL68tnEAGJVj4/rGzbZ87j1lodWhSDrrT95NzF/t3aC2bZ+w6NicylVj3S3O+MKPjVeTknyiegm0sx6Q1AzNm0Q6G8sLKw2PxEyZIiaATa952wPAWLn6TiPgqsnlKc6QX+96hGB7fjzso+6C2f4WVaIM/gZu+RYbkwpjf45MX2jYixAyYZ27LRuuZZbvBzbQQQFlA++9N4zozEFuimhKs6CKSZ8bowdCbhm0eAAFv+FLYZEwm2EysUTpyE3NZ1rttmAoq5Nq76N2oparNHstHUvWsCNNlMR84hZi1yNmb723orDx4svi+KSbWTuy6/3BZJ/1l/fy0f8KcpCT3JwsC0E7ifZSloIRqp3oo7PQ3yUaq3y5oXm0m0G46csIJeVgr63sTeZEYBFzXksn09Xs/mPHHFAcYSSv9shpLrbhgyYQtOAX7EhrSdS+Ye5ERpA8lsNy8QTGIA43lLbOAuZzRHzvvBKt4ReGn5eV/tFW2NNuvcQHKZr+QTZJBLHaQ==;5:YlHMJ6AYuItcAtcojGYkcmj0n+Qow1E3hQpwbwA67SVRBYc0+/yJkpJBY+dV7a2iCxFxn/KBp+Dkv9Z6zgfF4p/wIR60733Wh5/CHXZs73jHU6I767HO5B3W7sO8u2FD5efjXWzr+n9sKp+w4sLMxQ==;24:Lli2vYpVpGyHo95b+OOtsbaK1Utnw8nbkvYZrcoEFR1zOjeX/A5Y1tNXRjKFhYkFA/2tPhNMIO795dB0mVqdXTeihKnhRpoO2xf0MasRZJc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR15MB1088;7:4erOoDl9y4FQWHxOgmAMEZ5lPzTproKGO99u337dqDTYwNC5YuB4vebcIa7aZ0pI1OrR3zv6zLHAxnH18w9lQTDTMK2xNYeAjpa2G7URXFl+pOw9hzZrFGQh5yHzPe/o2zrW5qYQWGDcPbZyShj7+xnWGZ+lE6eujbFfV3Wv9EY3uHvfBs0KVPw55E2UdHNwejokAOBiVAKekzy4wrXWBKfPz+B7x2wuTrdFWD1plqUxUYACEZYOVYriPb5x0NF0BiBEmXN1YJ/uvXg9Kdbiax3HUwr75hQiqzFzf1stTyPB4Jf+egKYbtbzxLLnBS/oFPbRQ5+bUaur8PaMU8Cdug==;20:stU5EuCnEGInMClbBxALkK/7oacbYbyIzEsAAahNlLIqsCMTNFO9FgW+I1G3JB5ByNferiJGV0mNdODS7UcXyD1vl4ULU8a9PGPOZcA+/9Oq5/R1NbkzXrgDp47wbiSBUDW+Y0svhstWe3JqPnvlyWJhWlSBLsOuTrktVZc2adU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2017 13:13:32.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR15MB1088 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-16_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal! On Tue, May 16, 2017 at 11:29:56AM +0200, Michal Hocko wrote: > On Thu 11-05-17 20:16:23, Roman Gushchin wrote: > > Track the following reclaim counters for every memory cgroup: > > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > > PGLAZYFREED. > > yes, those are definitely useful. I have an old patch to add them as > well but never managed to clean it up and post... > > > These values are exposed using the memory.stats interface of cgroup v2. > > Is there any reason to not add them to v1? Not really, I'm just not sure, if it worth it to change v1 interface here. If you want, I can add them. > This should be rather trivial after recent changes from Johannes. If you're about memcg1_events[]/memcg1_event_names[], they can't be reused, because the pgscan and pgsteal values are both sums of direct and kswapd values: e.g. events[PGSTEAL_KSWAPD] + events[PGSTEAL_DIRECT]. > > > The meaning of each value is the same as for global counters, > > available using /proc/vmstat. > > > > Also, for consistency, rename mem_cgroup_count_vm_event() to > > count_memcg_event_mm(). > > > > Signed-off-by: Roman Gushchin > > Suggested-by: Johannes Weiner > > Cc: Johannes Weiner > > Cc: Tejun Heo > > Cc: Li Zefan > > Cc: Michal Hocko > > Cc: Vladimir Davydov > > Cc: cgroups@vger.kernel.org > > Cc: linux-doc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > the patch itself looks good to me. I will have to double check it after > I am done with what I am doing currently and then will add my Acked-by Thank you! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: Re: [PATCH] mm: per-cgroup memory reclaim stats Date: Tue, 16 May 2017 14:13:16 +0100 Message-ID: <20170516131316.GA7834@castle> References: <1494530183-30808-1-git-send-email-guro@fb.com> <20170516092956.GF2481@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=qvnqdHW/kl6stuQqEzv4sPcpXH5Nw+WVCOk80rJNYs8=; b=JkofeoO47pbTD7U+artLaAhh6jupZc8flpu0RdR///ylgH1DS5UthfNJGthIXAVWdyQR X4AyJesmku11AE/Vlv9Rujh4Hp+nhACqPMWHLCZoXUb68/2p0xhsaM7aSW8cbGEeaVyZ fdlZfPFJGWZwSlE59Pf/TOvgq1PeZr1762w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qvnqdHW/kl6stuQqEzv4sPcpXH5Nw+WVCOk80rJNYs8=; b=EmpLrxlsp6pfx3rc4Trm7IIGP3GJyAJFPFRjjdri7SnOPmqpHx+hpcXT9Nyy+qPRP/zdMY7Re5Sg5ayNxlbI9OObqHr5JNt7WGKUjA6jDT+4Kizz8H0zY8sEma5rl7zTAFUHe1UEP4W8tTDreKnITMXoOorb41lH0+v+ySjyXc4= Content-Disposition: inline In-Reply-To: <20170516092956.GF2481@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Johannes Weiner , Tejun Heo , Li Zefan , Vladimir Davydov , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Hi Michal! On Tue, May 16, 2017 at 11:29:56AM +0200, Michal Hocko wrote: > On Thu 11-05-17 20:16:23, Roman Gushchin wrote: > > Track the following reclaim counters for every memory cgroup: > > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > > PGLAZYFREED. > > yes, those are definitely useful. I have an old patch to add them as > well but never managed to clean it up and post... > > > These values are exposed using the memory.stats interface of cgroup v2. > > Is there any reason to not add them to v1? Not really, I'm just not sure, if it worth it to change v1 interface here. If you want, I can add them. > This should be rather trivial after recent changes from Johannes. If you're about memcg1_events[]/memcg1_event_names[], they can't be reused, because the pgscan and pgsteal values are both sums of direct and kswapd values: e.g. events[PGSTEAL_KSWAPD] + events[PGSTEAL_DIRECT]. > > > The meaning of each value is the same as for global counters, > > available using /proc/vmstat. > > > > Also, for consistency, rename mem_cgroup_count_vm_event() to > > count_memcg_event_mm(). > > > > Signed-off-by: Roman Gushchin > > Suggested-by: Johannes Weiner > > Cc: Johannes Weiner > > Cc: Tejun Heo > > Cc: Li Zefan > > Cc: Michal Hocko > > Cc: Vladimir Davydov > > Cc: cgroups@vger.kernel.org > > Cc: linux-doc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-mm@kvack.org > > the patch itself looks good to me. I will have to double check it after > I am done with what I am doing currently and then will add my Acked-by Thank you! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org