From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= Subject: Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Date: Tue, 16 May 2017 16:09:43 +0200 Message-ID: <20170516140943.ps2yufiukz6iurpl@latitude> References: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> Sender: linux-acpi-owner@vger.kernel.org To: Sricharan R Cc: robin.murphy@arm.com, will.deacon@arm.com, joro@8bytes.org, lorenzo.pieralisi@arm.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, m.szyprowski@samsung.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, tn@semihalf.com, hanjun.guo@linaro.org, okaya@codeaurora.org, robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, arnd@arndb.de, linux-arch@vger.kernel.org, gregkh@linuxfoundation.org List-Id: linux-arm-msm@vger.kernel.org Hi, I have a few suggestions on how to make this commit message more readable: On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: > While returning EPROBE_DEFER for iommu masters Add a comma at the end of this line > take in to account of iommu nodes that could be s/in to/into/ s/of iommu/of_iommu/ > marked in DT as 'status=disabled', in which case > simply return NULL and let the master's probe > continue rather than deferring. > > Signed-off-by: Sricharan R > Tested-by: Will Deacon > Acked-by: Will Deacon Thanks, Jonathan Neuschäfer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Tue, 16 May 2017 16:09:43 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Sricharan R Subject: Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Message-ID: <20170516140943.ps2yufiukz6iurpl@latitude> References: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, okaya@codeaurora.org, frowand.list@gmail.com, m.szyprowski@samsung.com, linux-arch@vger.kernel.org, lorenzo.pieralisi@arm.com, tn@semihalf.com, joro@8bytes.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, lenb@kernel.org, devicetree@vger.kernel.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, robh+dt@kernel.org, bhelgaas@google.com, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, hanjun.guo@linaro.org, sudeep.holla@arm.com, robin.murphy@arm.com Content-Type: text/plain; charset="utf-8" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: SGksIEkgaGF2ZSBhIGZldyBzdWdnZXN0aW9ucyBvbiBob3cgdG8gbWFrZSB0aGlzIGNvbW1pdCBt ZXNzYWdlIG1vcmUKcmVhZGFibGU6CgpPbiBUdWUsIE1heSAxNiwgMjAxNyBhdCAxMDo1NDoxM0FN ICswNTMwLCBTcmljaGFyYW4gUiB3cm90ZToKPiBXaGlsZSByZXR1cm5pbmcgRVBST0JFX0RFRkVS IGZvciBpb21tdSBtYXN0ZXJzCgpBZGQgYSBjb21tYSBhdCB0aGUgZW5kIG9mIHRoaXMgbGluZQoK PiB0YWtlIGluIHRvIGFjY291bnQgb2YgaW9tbXUgbm9kZXMgdGhhdCBjb3VsZCBiZQoKcy9pbiB0 by9pbnRvLwpzL29mIGlvbW11L29mX2lvbW11LwoKPiBtYXJrZWQgaW4gRFQgYXMgJ3N0YXR1cz1k aXNhYmxlZCcsIGluIHdoaWNoIGNhc2UKPiBzaW1wbHkgcmV0dXJuIE5VTEwgYW5kIGxldCB0aGUg bWFzdGVyJ3MgcHJvYmUKPiBjb250aW51ZSByYXRoZXIgdGhhbiBkZWZlcnJpbmcuCj4gCj4gU2ln bmVkLW9mZi1ieTogU3JpY2hhcmFuIFIgPHNyaWNoYXJhbkBjb2RlYXVyb3JhLm9yZz4KPiBUZXN0 ZWQtYnk6IFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0uY29tPgo+IEFja2VkLWJ5OiBXaWxs IERlYWNvbiA8d2lsbC5kZWFjb25AYXJtLmNvbT4KCgpUaGFua3MsCkpvbmF0aGFuIE5ldXNjaMOk ZmVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: j.neuschaefer@gmx.net (Jonathan =?utf-8?Q?Neusch=C3=A4fer?=) Date: Tue, 16 May 2017 16:09:43 +0200 Subject: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER In-Reply-To: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> References: <1494912253-25957-1-git-send-email-sricharan@codeaurora.org> Message-ID: <20170516140943.ps2yufiukz6iurpl@latitude> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, I have a few suggestions on how to make this commit message more readable: On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: > While returning EPROBE_DEFER for iommu masters Add a comma at the end of this line > take in to account of iommu nodes that could be s/in to/into/ s/of iommu/of_iommu/ > marked in DT as 'status=disabled', in which case > simply return NULL and let the master's probe > continue rather than deferring. > > Signed-off-by: Sricharan R > Tested-by: Will Deacon > Acked-by: Will Deacon Thanks, Jonathan Neusch?fer