From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 16 May 2017 14:42:54 +0000 Subject: [PATCH] drm/amd/powerplay: fix a signedness bugs Message-Id: <20170516144253.vvu3i6mbx3rv5uki@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Deucher , Rex Zhu Cc: David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Huang Rui , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Eric Huang , Ken Wang , Christian =?iso-8859-1?Q?K=F6nig?= Smatch complains about a signedness bug here: vega10_hwmgr.c:4202 vega10_force_clock_level() warn: always true condition '(i >= 0) => (0-u32max >= 0)' Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c index ad30f5d3a10d..2614af2f553f 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr, enum pp_clock_type type, uint32_t mask) { struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend); - uint32_t i; + int i; if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL) return -EINVAL; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/amd/powerplay: fix a signedness bugs Date: Tue, 16 May 2017 17:42:54 +0300 Message-ID: <20170516144253.vvu3i6mbx3rv5uki@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher , Rex Zhu Cc: David Airlie , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Huang Rui , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Eric Huang , Ken Wang , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org U21hdGNoIGNvbXBsYWlucyBhYm91dCBhIHNpZ25lZG5lc3MgYnVnIGhlcmU6CgoJdmVnYTEwX2h3 bWdyLmM6NDIwMiB2ZWdhMTBfZm9yY2VfY2xvY2tfbGV2ZWwoKQoJd2FybjogYWx3YXlzIHRydWUg Y29uZGl0aW9uICcoaSA+PSAwKSA9PiAoMC11MzJtYXggPj0gMCknCgpGaXhlczogN2I1MmRiMzlh NGMyICgiZHJtL2FtZC9wb3dlcnBsYXk6IGZpeCBidWcgc2Nsay9tY2xrIGxldmVsIGNhbid0IGJl IHNldCBvbiB2ZWdhMTAuIikKU2lnbmVkLW9mZi1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBl bnRlckBvcmFjbGUuY29tPgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJw bGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkv aHdtZ3IvdmVnYTEwX2h3bWdyLmMKaW5kZXggYWQzMGY1ZDNhMTBkLi4yNjE0YWYyZjU1M2YgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21n ci5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21n ci5jCkBAIC00MTg2LDcgKzQxODYsNyBAQCBzdGF0aWMgaW50IHZlZ2ExMF9mb3JjZV9jbG9ja19s ZXZlbChzdHJ1Y3QgcHBfaHdtZ3IgKmh3bWdyLAogCQllbnVtIHBwX2Nsb2NrX3R5cGUgdHlwZSwg dWludDMyX3QgbWFzaykKIHsKIAlzdHJ1Y3QgdmVnYTEwX2h3bWdyICpkYXRhID0gKHN0cnVjdCB2 ZWdhMTBfaHdtZ3IgKikoaHdtZ3ItPmJhY2tlbmQpOwotCXVpbnQzMl90IGk7CisJaW50IGk7CiAK IAlpZiAoaHdtZ3ItPmRwbV9sZXZlbCAhPSBBTURfRFBNX0ZPUkNFRF9MRVZFTF9NQU5VQUwpCiAJ CXJldHVybiAtRUlOVkFMOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK