Am 16.05.2017 um 17:05 hat Eric Blake geschrieben: > On 05/16/2017 09:16 AM, Kevin Wolf wrote: > > Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben: > >> - offset_to_bootsector is the number of sectors up to FAT bootsector > >> - offset_to_fat is the number of sectors up to first File Allocation Table > >> - offset_to_root_dir is the number of sectors up to root directory sector > > > > Hm... These names make me think of byte offsets. Not completely opposed > > to them, but if anyone can think of something better...? > > I _want_ us to move towards byte offsets. Thinking in sector offsets is > madness, especially since I already have patches posted to make > bdrv_get_block_status() converted to a byte-wise interface. > > How hard is it to make all of the new variables be byte offsets, then > scale them to sectors as needed? You can assert() that the byte offsets > are sector-aligned, so that the scaling doesn't have to worry about > rounding effects during the divisions. If we want to convert it to bytes internally (I'm not sure how useful it is with vvfat), that would definitely be a separate patch or even series. Kevin