From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D1DC21A16EDC for ; Tue, 16 May 2017 08:53:12 -0700 (PDT) Date: Tue, 16 May 2017 17:53:07 +0200 From: Christoph Hellwig Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t Message-ID: <20170516155307.GA2086@lst.de> References: <20170515154308.26739-1-hch@lst.de> <20170515154308.26739-18-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Amir Goldstein Cc: linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, Mimi Zohar , linux-kernel , Steven Whitehouse , David Howells , linux-fsdevel , Andy Shevchenko , Shaohua Li , Christoph Hellwig List-ID: On Mon, May 15, 2017 at 10:38:18PM +0300, Amir Goldstein wrote: > On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > > > Signed-off-by: Christoph Hellwig > > --- > > > --- a/fs/xfs/xfs_mount.c > > +++ b/fs/xfs/xfs_mount.c > > @@ -75,7 +75,7 @@ xfs_uuid_mount( > > > > /* Publish UUID in struct super_block */ > > BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t)); > > BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t Yeah, you mentioned that last time and I forgot about it. Fixed up in the git tree and for the next repost. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t Date: Tue, 16 May 2017 17:53:07 +0200 Message-ID: <20170516155307.GA2086@lst.de> References: <20170515154308.26739-1-hch@lst.de> <20170515154308.26739-18-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Amir Goldstein Cc: Christoph Hellwig , Andy Shevchenko , linux-fsdevel , Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel List-Id: linux-raid.ids On Mon, May 15, 2017 at 10:38:18PM +0300, Amir Goldstein wrote: > On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > > > Signed-off-by: Christoph Hellwig > > --- > > > --- a/fs/xfs/xfs_mount.c > > +++ b/fs/xfs/xfs_mount.c > > @@ -75,7 +75,7 @@ xfs_uuid_mount( > > > > /* Publish UUID in struct super_block */ > > BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t)); > > BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t Yeah, you mentioned that last time and I forgot about it. Fixed up in the git tree and for the next repost. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbdEPPxL (ORCPT ); Tue, 16 May 2017 11:53:11 -0400 Received: from verein.lst.de ([213.95.11.211]:48861 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750950AbdEPPxJ (ORCPT ); Tue, 16 May 2017 11:53:09 -0400 Date: Tue, 16 May 2017 17:53:07 +0200 From: Christoph Hellwig To: Amir Goldstein Cc: Christoph Hellwig , Andy Shevchenko , linux-fsdevel , Shaohua Li , Dan Williams , David Howells , Steven Whitehouse , Mimi Zohar , linux-xfs , linux-raid@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t Message-ID: <20170516155307.GA2086@lst.de> References: <20170515154308.26739-1-hch@lst.de> <20170515154308.26739-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 10:38:18PM +0300, Amir Goldstein wrote: > On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > > > Signed-off-by: Christoph Hellwig > > --- > > > --- a/fs/xfs/xfs_mount.c > > +++ b/fs/xfs/xfs_mount.c > > @@ -75,7 +75,7 @@ xfs_uuid_mount( > > > > /* Publish UUID in struct super_block */ > > BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t)); > > BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t Yeah, you mentioned that last time and I forgot about it. Fixed up in the git tree and for the next repost.