From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753581AbdEPWuX (ORCPT ); Tue, 16 May 2017 18:50:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:52102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdEPWuT (ORCPT ); Tue, 16 May 2017 18:50:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01D5E239CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 16 May 2017 18:50:16 -0400 From: Steven Rostedt To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Mark Rutland , Greg Kroah-Hartman Subject: Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early Message-ID: <20170516185016.20467717@gandalf.local.home> In-Reply-To: References: <20170516184231.564888231@linutronix.de> <20170516184736.272225698@linutronix.de> <20170516151236.3ca5d9ae@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2017 00:46:37 +0200 (CEST) Thomas Gleixner wrote: > > > --- a/lib/smp_processor_id.c > > > +++ b/lib/smp_processor_id.c > > > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp > > > /* > > > * It is valid to assume CPU-locality during early bootup: > > > */ > > > - if (system_state != SYSTEM_RUNNING) > > > + if (system_state < SYSTEM_SCHEDULING) > > > > Do we want to ignore halting or rebooting too? > > I don't think so. After setting those states, interesting stuff like > device_shutdown() gets invoked. We want the coverage there. Then I'd suggest that you update the change log, as this patch also adds coverage to those states as well. -- Steve