From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbdEPQL2 (ORCPT ); Tue, 16 May 2017 12:11:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:51720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbdEPQLY (ORCPT ); Tue, 16 May 2017 12:11:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C923523961 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Wed, 17 May 2017 01:11:15 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: "Naveen N. Rao" , Shuah Khan , Michael Ellerman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Masami Hiramatsu Subject: Re: [PATCH 2/4] ftrace/instances: Clear function triggers when removing instances Message-Id: <20170517011115.3e5e6d74a0602fcc2467c886@kernel.org> In-Reply-To: <20170515121103.65b811cb@gandalf.local.home> References: <437c3409d58c2ab065233df57d82425a90c5e9e1.1494702964.git.naveen.n.rao@linux.vnet.ibm.com> <20170515112115.36825c24@gandalf.local.home> <20170515121103.65b811cb@gandalf.local.home> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 May 2017 12:11:03 -0400 Steven Rostedt wrote: > On Mon, 15 May 2017 11:21:15 -0400 > Steven Rostedt wrote: > > > On Sun, 14 May 2017 01:01:02 +0530 > > "Naveen N. Rao" wrote: > > > > > If instance directories are deleted while there are registered function > > > triggers: > > > > > > # cd /sys/kernel/debug/tracing/instances > > > # mkdir test > > > # echo "schedule:enable_event:sched:sched_switch" > test/set_ftrace_filter > > > # rmdir test > > > Unable to handle kernel paging request for data at address 0x00000008 > > > Unable to handle kernel paging request for data at address 0x00000008 > > > Faulting instruction address: 0xc0000000021edde8 > > > Oops: Kernel access of bad area, sig: 11 [#1] > > > SMP NR_CPUS=2048 > > > NUMA > > > pSeries > > > > Looks like this patch needs to be marked for stable, and go in right > > away. I may also do the same for the ftracetest bashism patch with > > Masami's approval. I may also slip in the ftracetest for the bug that > > this patch fixes. > > As this patch fixes a bug that was introduced with the 4.12 merge > window. Thus, it's not stable worthy (stable isn't affected). Although, > I'll wait on Masami to see if that should go to stable. Hm, for the bashism fix, that is not a show-stopper... and also, newer ftracetest should work on older kernel. So I don't think it needs to go stable. Thank you, > > -- Steve > -- Masami Hiramatsu