From: David Gibson <david@gibson.dropbear.id.au>
To: Andrea Bolognani <abologna@redhat.com>
Cc: thuth@redhat.com, lvivier@redhat.com, mdroth@linux.vnet.ibm.com,
aik@ozlabs.ru, bharata@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types
Date: Thu, 18 May 2017 14:51:03 +1000 [thread overview]
Message-ID: <20170518045103.GT15596@umbus.fritz.box> (raw)
In-Reply-To: <1495011125.4663.5.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
On Wed, May 17, 2017 at 10:52:05AM +0200, Andrea Bolognani wrote:
> On Wed, 2017-05-17 at 16:35 +1000, David Gibson wrote:
> > 152ef80 "pseries: Rewrite CAS PVR compatibility logic" incorrectly
> > introduced a guest-visible behaviour change into existing versioned
> > machine type. Patch 2/2 corrects this change, while 1/2 is a
> > preliminary clean up to make that easier.
> >
> > Unfortunately, this bug is already in the released qemu-2.9.0. Once
> > this is ready to merge for master, I'll make a backport to apply for
> > 2.9.1 as well.
> >
> > David Gibson (2):
> > pseries: Split CAS PVR negotiation out into a separate function
> > pseries: Restore PVR negotiation logic for pre-2.9 machine types
> >
> > hw/ppc/spapr.c | 3 ++
> > hw/ppc/spapr_hcall.c | 131 +++++++++++++++++++++++++++++++++++++++++++------
> > include/hw/ppc/spapr.h | 1 +
> > 3 files changed, 119 insertions(+), 16 deletions(-)
>
> I gave it a spin and I can no longer reproduce the issue,
> so for the entire series:
>
> Tested-by: Andrea Bolognani <abologna@redhat.com>
I'm actually kind of astonished it worked at all given the bug that
Laurent pointed out.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-18 5:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 6:35 [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types David Gibson
2017-05-17 6:35 ` [Qemu-devel] [RFC 1/2] pseries: Split CAS PVR negotiation out into a separate function David Gibson
2017-05-17 8:55 ` Laurent Vivier
2017-05-17 15:56 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-05-18 4:37 ` David Gibson
2017-05-17 6:35 ` [Qemu-devel] [RFC 2/2] pseries: Restore PVR negotiation logic for pre-2.9 machine types David Gibson
2017-05-17 9:21 ` Laurent Vivier
2017-05-17 16:32 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2017-05-17 8:52 ` [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older " Andrea Bolognani
2017-05-18 4:51 ` David Gibson [this message]
2017-05-18 6:58 ` Andrea Bolognani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518045103.GT15596@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=abologna@redhat.com \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.