All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [CFT] Always enable SMP mode on MP capable CPUs
Date: Thu, 18 May 2017 11:52:10 +0100	[thread overview]
Message-ID: <20170518105209.GN22219@n2100.armlinux.org.uk> (raw)

As a result of a recent bug report, it has been found that certain CPUs
must always have SMP mode enabled in order for the caches to work.

Remove the conditional on setting the SMP bit(s).

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
This needs to be tested on:

- Cortex A5MP
- Cortex A9MP
- Cortex R7MP
- Cortex A7MP
- Cortex A12MP
- Cortex A15MP
- Cortex A17MP
- Brahma B15

and any other CPU that mis-identifies itself with a MP-capable CPUID
signature that might match one of those CPUs.  I'm aware of a Cortex
A9 CPU out there that does mis-identify itself as SMP capable but
isn't:

        @ Core indicates it is SMP. Check for Aegis SOC where a single
        @ Cortex-A9 CPU is present but SMP operations fault.

This will also need testing.

 arch/arm/mm/proc-v7.S | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 01d64c0b2563..4d48a4cf563b 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -286,14 +286,10 @@ ENDPROC(cpu_pj4b_do_resume)
 	stmia	r12, {r1-r6, lr}		@ v7_invalidate_l1 touches r0-r6
 	bl      v7_invalidate_l1
 	ldmia	r12, {r1-r6, lr}
-#ifdef CONFIG_SMP
+	mrc	p15, 0, r0, c1, c0, 1
 	orr	r10, r10, #(1 << 6)		@ Enable SMP/nAMP mode
-	ALT_SMP(mrc	p15, 0, r0, c1, c0, 1)
-	ALT_UP(mov	r0, r10)		@ fake it for UP
 	orr	r10, r10, r0			@ Set required bits
-	teq	r10, r0				@ Were they already set?
-	mcrne	p15, 0, r10, c1, c0, 1		@ No, update register
-#endif
+	mcr	p15, 0, r10, c1, c0, 1		@ No, update register
 	b	__v7_setup_cont
 
 /*

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently@9.6Mbps down 400kbps up
according to speedtest.net.

             reply	other threads:[~2017-05-18 10:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 10:52 Russell King - ARM Linux [this message]
2017-05-18 18:09 ` [CFT] Always enable SMP mode on MP capable CPUs Fabio Estevam
2017-05-19 17:07   ` Fabio Estevam
2017-05-19 17:15     ` Russell King - ARM Linux
2017-05-24 15:38       ` Tony Lindgren
2017-05-24 15:38         ` Tony Lindgren
2017-05-25 14:48         ` Russell King - ARM Linux
2017-05-25 14:48           ` Russell King - ARM Linux
2017-05-25 15:11           ` Tony Lindgren
2017-05-25 15:11             ` Tony Lindgren
2017-05-25 18:05             ` Russell King - ARM Linux
2017-05-25 18:05               ` Russell King - ARM Linux
2017-05-25 22:13               ` Tony Lindgren
2017-05-25 22:13                 ` Tony Lindgren
2017-05-26 11:22                 ` afzal mohammed
2017-05-26 11:22                   ` afzal mohammed
2017-05-27 13:22                   ` Russell King - ARM Linux
2017-05-27 13:22                     ` Russell King - ARM Linux
2017-05-31 14:39                     ` Tony Lindgren
2017-05-31 14:39                       ` Tony Lindgren
2017-05-31 14:59                       ` Russell King - ARM Linux
2017-05-31 14:59                         ` Russell King - ARM Linux
2017-05-31 15:07                         ` Tony Lindgren
2017-05-31 15:07                           ` Tony Lindgren
2017-05-24 15:50 ` afzal mohammed
2017-05-24 15:50   ` afzal mohammed
2017-05-25 16:15 ` Florian Fainelli
2017-05-25 16:56   ` Russell King - ARM Linux
2017-05-25 17:10     ` Tony Lindgren
2017-05-25 17:10       ` Tony Lindgren
2017-05-25 17:24     ` Florian Fainelli
2017-05-26  9:44 ` Vladimir Murzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518105209.GN22219@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.