From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932984AbdESBaD (ORCPT ); Thu, 18 May 2017 21:30:03 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34464 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932328AbdESB37 (ORCPT ); Thu, 18 May 2017 21:29:59 -0400 Date: Thu, 18 May 2017 20:29:57 -0500 From: Rob Herring To: sean.wang@mediatek.com Cc: dan.j.williams@intel.com, vinod.koul@intel.com, mark.rutland@arm.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, keyhaede@gmail.com Subject: Re: [PATCH 1/2] dt-bindings: dmaengine: Add Mediatek High-Speed DMA controller bindings Message-ID: <20170519012957.q3dr73qharbwtvc3@rob-hp-laptop> References: <07cc981fbf9620459d1ac63e8720eaa2dd110048.1494830885.git.sean.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07cc981fbf9620459d1ac63e8720eaa2dd110048.1494830885.git.sean.wang@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 15, 2017 at 02:59:26PM +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > Document the devicetree bindings for Mediatek High-Speed DMA controller > which could be found on MT7623 SoC or other similar Mediatek SoCs. > > Signed-off-by: Sean Wang > --- > .../devicetree/bindings/dma/mtk-hsdma.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/mtk-hsdma.txt > > diff --git a/Documentation/devicetree/bindings/dma/mtk-hsdma.txt b/Documentation/devicetree/bindings/dma/mtk-hsdma.txt > new file mode 100644 > index 0000000..62cdda4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/mtk-hsdma.txt > @@ -0,0 +1,30 @@ > +Mediatek High-Speed DMA Controller > +================================== > + > +This driver follows the generic DMA bindings defined in dma/dma.txt. > + > +Required properties: > + > +- compatible: Must be one of > + "mediatek,mt7623-hsdma". > +- reg: Should contain the register's base address and length. > +- interrupts: Should contain a reference to the interrupt used by this > + device. > +- clocks: Should be the clock specifiers corresponding to the entry in > + clock-names property. > +- clock-names: Should contain "hsdma" entries. > +- #dma-cells: The length of the DMA specifier, must be <1>. This one cell > + in dmas property of a client device represents the channel > + number. > +Example: > + > + hsdma: hsdma@1b007000 { dma-controller@... > + compatible = "mediatek,mt7623-hsdma"; > + reg = <0 0x1b007000 0 0x1000>; > + interrupts = ; > + clocks = <ðsys CLK_ETHSYS_HSDMA>; > + clock-names = "hsdma"; > + status = "okay"; Don't need to show status in examples. With those, Acked-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Thu, 18 May 2017 20:29:57 -0500 Subject: [PATCH 1/2] dt-bindings: dmaengine: Add Mediatek High-Speed DMA controller bindings In-Reply-To: <07cc981fbf9620459d1ac63e8720eaa2dd110048.1494830885.git.sean.wang@mediatek.com> References: <07cc981fbf9620459d1ac63e8720eaa2dd110048.1494830885.git.sean.wang@mediatek.com> Message-ID: <20170519012957.q3dr73qharbwtvc3@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 15, 2017 at 02:59:26PM +0800, sean.wang at mediatek.com wrote: > From: Sean Wang > > Document the devicetree bindings for Mediatek High-Speed DMA controller > which could be found on MT7623 SoC or other similar Mediatek SoCs. > > Signed-off-by: Sean Wang > --- > .../devicetree/bindings/dma/mtk-hsdma.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/mtk-hsdma.txt > > diff --git a/Documentation/devicetree/bindings/dma/mtk-hsdma.txt b/Documentation/devicetree/bindings/dma/mtk-hsdma.txt > new file mode 100644 > index 0000000..62cdda4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/mtk-hsdma.txt > @@ -0,0 +1,30 @@ > +Mediatek High-Speed DMA Controller > +================================== > + > +This driver follows the generic DMA bindings defined in dma/dma.txt. > + > +Required properties: > + > +- compatible: Must be one of > + "mediatek,mt7623-hsdma". > +- reg: Should contain the register's base address and length. > +- interrupts: Should contain a reference to the interrupt used by this > + device. > +- clocks: Should be the clock specifiers corresponding to the entry in > + clock-names property. > +- clock-names: Should contain "hsdma" entries. > +- #dma-cells: The length of the DMA specifier, must be <1>. This one cell > + in dmas property of a client device represents the channel > + number. > +Example: > + > + hsdma: hsdma at 1b007000 { dma-controller at ... > + compatible = "mediatek,mt7623-hsdma"; > + reg = <0 0x1b007000 0 0x1000>; > + interrupts = ; > + clocks = <ðsys CLK_ETHSYS_HSDMA>; > + clock-names = "hsdma"; > + status = "okay"; Don't need to show status in examples. With those, Acked-by: Rob Herring