From: Stephen Hemminger <stephen@networkplumber.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jork Loeser <jloeser@microsoft.com>,
olaf@aepfle.de, sthemmin@microsoft.com,
linux-pci@vger.kernel.org, jasowang@redhat.com,
linux-kernel@vger.kernel.org, marcelo.cerri@canonical.com,
helgaas@kernel.org, apw@canonical.com,
devel@linuxdriverproject.org, vkuznets@redhat.com,
leann.ogasawara@canonical.com
Subject: Re: [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2
Date: Fri, 19 May 2017 08:21:22 -0700 [thread overview]
Message-ID: <20170519082122.7f56aa38@xeon-e3> (raw)
In-Reply-To: <20170519112701.adqxvpkorrthjf7i@mwanda>
On Fri, 19 May 2017 14:27:01 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > /*
> > + * HV_VP_SET available
> > + */
> > +#define HV_X64_EX_PROCESSOR_MASKS_RECOMMENDED (1 << 11)
>
> Use BIT(11). I thought checkpatch.pl complains about this but I guess
> that's only with the --strict option.
Since all the other field values are encoded as shifts, doing something
different for this field stands out. Therefore just use (1 << 11)
or change all the previous values using BIT() macro
next prev parent reply other threads:[~2017-05-19 15:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 19:14 Hyper-V vPCI: Use current vPCI protocol Jork Loeser
2017-05-18 19:14 ` [PATCH 1/4] Hyper-V vPCI: Minor format and semantic fix Jork Loeser
2017-05-18 19:14 ` [PATCH 2/4] Hyper-V vPCI: Use page allocation for hbus structure Jork Loeser
2017-05-18 19:14 ` [PATCH 3/4] Hyper-V vPCI: Add vPCI version protocol negotiation Jork Loeser
2017-05-19 11:20 ` Dan Carpenter
2017-05-18 19:14 ` [PATCH 4/4] Hyper-V vPCI: use vPCI protocol version 1.2 Jork Loeser
2017-05-18 23:58 ` Stephen Hemminger
2017-05-19 2:13 ` Jork Loeser
2017-05-19 2:13 ` Jork Loeser
2017-05-19 10:03 ` Vitaly Kuznetsov
2017-05-19 10:03 ` Vitaly Kuznetsov
2017-05-19 13:48 ` KY Srinivasan
2017-05-19 13:48 ` KY Srinivasan
2017-05-19 9:59 ` Vitaly Kuznetsov
2017-05-19 9:59 ` Vitaly Kuznetsov
2017-05-24 14:58 ` Jork Loeser
2017-05-24 14:58 ` Jork Loeser
2017-05-19 11:27 ` Dan Carpenter
2017-05-19 15:21 ` Stephen Hemminger [this message]
2017-05-24 15:07 ` Jork Loeser
2017-05-24 15:07 ` Jork Loeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519082122.7f56aa38@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=helgaas@kernel.org \
--cc=jasowang@redhat.com \
--cc=jloeser@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.