From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932683AbdEUXT5 (ORCPT ); Sun, 21 May 2017 19:19:57 -0400 Received: from server.atrad.com.au ([150.101.241.2]:51870 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbdEUXTz (ORCPT ); Sun, 21 May 2017 19:19:55 -0400 Date: Mon, 22 May 2017 08:48:56 +0930 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/8] platform/x86: fujitsu-laptop: track the last instantiated FUJ02E3 ACPI device Message-ID: <20170521231856.GC28475@marvin.atrad.com.au> References: <20170519074448.12716-1-kernel@kempniu.pl> <20170519074448.12716-6-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170519074448.12716-6-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2017 at 09:44:45AM +0200, Micha?? K??pie?? wrote: > It is easier to simply store a module-wide > pointer to the last (most likely only) FUJ02E3 ACPI device found, make > the aforementioned API use it and cover our bases by warning the user if > firmware exposes multiple FUJ02E3 ACPI devices. > : > @@ -788,6 +789,9 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device) > if (!priv) > return -ENOMEM; > > + WARN_ONCE(fext, "More than one FUJ02E3 ACPI device was found. Driver may not work as intended."); > + fext = device; > + > fujitsu_laptop = priv; > fujitsu_laptop->acpi_handle = device->handle; > sprintf(acpi_device_name(device), "%s", I thought WARN_ONCE() printed the warning when it was encountered for the first time and then suppressed it on all other occasions. If this is true then we'll get the warning even when there is only one FUJ02E3 in the system. Am I missing something? Regards jonathan