From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 0/3] drivers/net: add support for IF-MIB and
 EtherLike-MIB
Date: Mon, 22 May 2017 09:11:00 -0700
Message-ID: <20170522091100.27f080e3@xeon-e3>
References: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, reshma.pattan@intel.com, deepak.k.jain@intel.com,
 harry.van.haaren@intel.com
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id B0DB628EE
 for <dev@dpdk.org>; Mon, 22 May 2017 18:11:08 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id e193so86793832pfh.0
 for <dev@dpdk.org>; Mon, 22 May 2017 09:11:08 -0700 (PDT)
In-Reply-To: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 22 May 2017 16:31:59 +0200
Michal Jastrzebski <michalx.k.jastrzebski@intel.com> wrote:

> Extend Intel NICs (i40e, ixgbe, e1000) xstats for IF-MIB and
> EtherLike-MIB.
> 
> If-MIB xstats:
> ifNumber
> ifIndex
> ifType
> ifMtu
> ifSpeed
> ifPhysAddress
> ifOperStatus
> ifLastChange
> ifHighSpeed
> ifConnectorPresent
> ifCounterDiscontinuityTime
> 
> EtherLike-MIB xstats:
> dot3PauseOperMode
> dot3StatsDuplexStatus
> dot3StatsRateControlAbility
> dot3StatsRateControlStatus
> dot3ControlFunctionsSupported
> 
> Michal Jastrzebski (3):
>   drivers/net: add support for IF-MIB and EtherLike-MIB for e1000
>   drivers/net: add support for IF-MIB and EtherLike-MIB for i40e
>   drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe
> 
>  drivers/net/e1000/e1000_ethdev.h |   59 ++++++++
>  drivers/net/e1000/igb_ethdev.c   |  296 ++++++++++++++++++++++++++++++++++----
>  drivers/net/i40e/i40e_ethdev.c   |  171 +++++++++++++++++++++-
>  drivers/net/i40e/i40e_ethdev.h   |   60 ++++++++
>  drivers/net/ixgbe/ixgbe_ethdev.c |  275 ++++++++++++++++++++++++++++++++---
>  drivers/net/ixgbe/ixgbe_ethdev.h |   59 ++++++++
>  6 files changed, 878 insertions(+), 42 deletions(-)
> 

Having all the SNMP MIB information is a worth goal. Thank you for starting
the effort.

But you need to rethink how you are implementing this.
Doing it in a driver specific manner is not helpful to application writers.
All API's for features like this should be at ethdev level, and be supported
by generic code.

If you are going to add something like this it has to work for all devices
virtual, physical, layered and not just Intel hardware. It is a much
bigger task.