From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dCll1-0008SB-PK for kexec@lists.infradead.org; Mon, 22 May 2017 11:44:17 +0000 Date: Mon, 22 May 2017 13:43:51 +0200 From: Simon Horman Subject: Re: [PATCH] Handle additional e820 memmap type strings Message-ID: <20170522114351.GF16822@verge.net.au> References: <1494432217-26092-1-git-send-email-eric.devolder@oracle.com> <20170515140711.GB21797@x1> <20170519091538.GA24903@x1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170519091538.GA24903@x1> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Baoquan He Cc: andrew.cooper3@citrix.com, daniel.kiper@oracle.com, Eric DeVolder , kexec@lists.infradead.org, konrad.wilk@oracle.com On Fri, May 19, 2017 at 05:15:38PM +0800, Baoquan He wrote: > On 05/17/17 at 07:51am, Eric DeVolder wrote: > > > > diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c > > > > index 4d84f00..1ee214a 100644 > > > > --- a/kexec/firmware_memmap.c > > > > +++ b/kexec/firmware_memmap.c > > > > @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct memory_range *range) > > > > range->type = RANGE_RESERVED; > > > > else if (strcmp(type, "reserved") == 0) > > > > range->type = RANGE_RESERVED; > > > > + else if (strcmp(type, "Reserved") == 0) > > > > + range->type = RANGE_RESERVED; > > > > + else if (strcmp(type, "Unknown E820 type") == 0) > > > > + range->type = RANGE_RESERVED; > > > > > > Should we change the "reserved" one to "Reserved" so that we don't need > > > to have "reserved" and "Reserved" at the same time? > > > > The lower-case "reserved" has been in use by the kernel for quite a long > > while, and upper-case "Reserved" has been recently introduced. I think > > removing lower-case "reserved" would result in problems with existing, > > older, kernels that still would be using "reserved". > > Thanks. Then it looks good to me. Ack. > > Simon might pick several patches one time every several days. Please > wait. Yes, I try to pick up new patches within a few working days. I have applied this one. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec