From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v5] dma-buf/sync-file: Defer creation of sync_file->name Date: Mon, 22 May 2017 21:31:56 +0200 Message-ID: <20170522193156.jp4ab7gi6pehjerp@phenom.ffwll.local> References: <20170515101055.10266-1-chris@chris-wilson.co.uk> <20170516111042.24719-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 100126E286 for ; Mon, 22 May 2017 19:32:01 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id k15so33846994wmh.3 for ; Mon, 22 May 2017 12:32:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170516111042.24719-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMTYsIDIwMTcgYXQgMTI6MTA6NDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IENvbnN0cnVjdGluZyB0aGUgbmFtZSB0YWtlcyB0aGUgbWFqb3JpdHkgb2YgdGhlIHRp bWUgZm9yIGFsbG9jYXRpbmcgYQo+IHN5bmNfZmlsZSB0byB3cmFwIGEgZmVuY2UsIGFuZCB0aGUg bmFtZSBpcyB2ZXJ5IHJhcmVseSB1c2VkIChvbmx5IHZpYQo+IHRoZSBzeW5jX2ZpbGUgc3RhdHVz IHVzZXIgaW50ZXJmYWNlKS4gVG8gcmVkdWNlIHRoZSBpbXBhY3Qgb24gdGhlIGNvbW1vbgo+IHBh dGggKHRoYXQgb2YgY3JlYXRpbmcgc3luY19maWxlIHRvIHBhc3MgYXJvdW5kKSwgZGVmZXIgdGhl IGNvbnN0cnVjdGlvbgo+IG9mIHRoZSBuYW1lIHVudGlsIGl0IGlzIGZpcnN0IHVzZWQuCj4gCj4g djI6IFVwZGF0ZSBrZXJuZWxkb2MgKGtidWlsZCB0ZXN0IHJvYm90KQo+IHYzOiBzeW5jX2RlYnVn LmMgd2FzIHBlZWtpbmcgYXQgdGhlIG5hbWUKPiB2NDogQ29tbWVudCB1cG9uIHRoZSBwb3RlbnRp YWwgcmFjZSBiZXR3ZWVuIHR3byB1c2VycyBvZgo+IHN5bmNfZmlsZV9nZXRfbmFtZSgpIGFuZCBj bGFpbSB0aGF0IHN1Y2ggYSByYWNlIGlzIGJlbG93IHRoZSBsZXZlbCBvZgo+IG5vdGljZS4gSG93 ZXZlciwgdG8gcHJldmVudCBhbnkgZnV0dXJlIG51aXNhbmNlLCB1c2UgYSBnbG9iYWwgc3Bpbmxv Y2sKPiB0byBzZXJpYWxpemUgdGhlIGFzc2lnbm1lbnQgb2YgdGhlIG5hbWUuCj4gdjU6IENvbXBs ZXRlbHkgYXZvaWQgdGhlIHJlYWQvd3JpdGUgcmFjZSBieSBvbmx5IHN0b3JpbmcgdGhlIG5hbWUg cGFzc2VkCj4gaW4gZnJvbSB0aGUgdXNlciBpbnNpZGUgc3luY19maWxlLT51c2VyX25hbWUgYW5k IHBhc3NpbmcgaW4gYSBidWZmZXIgdG8KPiBkeW5hbWljYWxseSBjb25zdHJ1Y3QgdGhlIG5hbWUg b3RoZXJ3aXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8ub3Jn Pgo+IENjOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm9AcGFkb3Zhbi5vcmc+Cj4gQ2M6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IERhdmlkIEhlcnJtYW5uIDxk aC5oZXJybWFubkBnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVn LmMgfCAgNCArKystCj4gIGRyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYyAgfCAzOSArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPiAgaW5jbHVkZS9saW51eC9zeW5jX2Zp bGUuaCAgICB8ICA1ICsrKy0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygrKSwg MTAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2Rl YnVnLmMgYi9kcml2ZXJzL2RtYS1idWYvc3luY19kZWJ1Zy5jCj4gaW5kZXggNGIxNzMxZWU3NDU4 Li41OWEzYjJmOGVlOTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL3N5bmNfZGVidWcu Ywo+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2RlYnVnLmMKPiBAQCAtMTMyLDkgKzEzMiwx MSBAQCBzdGF0aWMgdm9pZCBzeW5jX3ByaW50X29iaihzdHJ1Y3Qgc2VxX2ZpbGUgKnMsIHN0cnVj dCBzeW5jX3RpbWVsaW5lICpvYmopCj4gIHN0YXRpYyB2b2lkIHN5bmNfcHJpbnRfc3luY19maWxl KHN0cnVjdCBzZXFfZmlsZSAqcywKPiAgCQkJCSAgc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxl KQo+ICB7Cj4gKwljaGFyIGJ1ZlsxMjhdOwo+ICAJaW50IGk7Cj4gIAo+IC0Jc2VxX3ByaW50Zihz LCAiWyVwXSAlczogJXNcbiIsIHN5bmNfZmlsZSwgc3luY19maWxlLT5uYW1lLAo+ICsJc2VxX3By aW50ZihzLCAiWyVwXSAlczogJXNcbiIsIHN5bmNfZmlsZSwKPiArCQkgICBzeW5jX2ZpbGVfZ2V0 X25hbWUoc3luY19maWxlLCBidWYsIHNpemVvZihidWYpKSwKPiAgCQkgICBzeW5jX3N0YXR1c19z dHIoZG1hX2ZlbmNlX2dldF9zdGF0dXMoc3luY19maWxlLT5mZW5jZSkpKTsKPiAgCj4gIAlpZiAo ZG1hX2ZlbmNlX2lzX2FycmF5KHN5bmNfZmlsZS0+ZmVuY2UpKSB7Cj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+ IGluZGV4IGM5ZWI0OTk3Y2ZjYy4uZDdlMjE5ZDI2NjlkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv ZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+ IEBAIC04MCwxMSArODAsNiBAQCBzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGVfY3JlYXRlKHN0 cnVjdCBkbWFfZmVuY2UgKmZlbmNlKQo+ICAKPiAgCXN5bmNfZmlsZS0+ZmVuY2UgPSBkbWFfZmVu Y2VfZ2V0KGZlbmNlKTsKPiAgCj4gLQlzbnByaW50ZihzeW5jX2ZpbGUtPm5hbWUsIHNpemVvZihz eW5jX2ZpbGUtPm5hbWUpLCAiJXMtJXMlbGx1LSVkIiwKPiAtCQkgZmVuY2UtPm9wcy0+Z2V0X2Ry aXZlcl9uYW1lKGZlbmNlKSwKPiAtCQkgZmVuY2UtPm9wcy0+Z2V0X3RpbWVsaW5lX25hbWUoZmVu Y2UpLCBmZW5jZS0+Y29udGV4dCwKPiAtCQkgZmVuY2UtPnNlcW5vKTsKPiAtCj4gIAlyZXR1cm4g c3luY19maWxlOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woc3luY19maWxlX2NyZWF0ZSk7Cj4gQEAg LTEyOSw2ICsxMjQsMzYgQEAgc3RydWN0IGRtYV9mZW5jZSAqc3luY19maWxlX2dldF9mZW5jZShp bnQgZmQpCj4gIH0KPiAgRVhQT1JUX1NZTUJPTChzeW5jX2ZpbGVfZ2V0X2ZlbmNlKTsKPiAgCj4g Ky8qKgo+ICsgKiBzeW5jX2ZpbGVfZ2V0X25hbWUgLSBnZXQgdGhlIG5hbWUgb2YgdGhlIHN5bmNf ZmlsZQo+ICsgKiBAc3luY19maWxlOgkJc3luY19maWxlIHRvIGdldCB0aGUgZmVuY2UgZnJvbQo+ ICsgKiBAYnVmOgkJZGVzdGluYXRpb24gYnVmZmVyIHRvIGNvcHkgc3luY19maWxlIG5hbWUgaW50 bwo+ICsgKiBAbGVuOgkJYXZhaWxhYmxlIHNpemUgb2YgZGVzdGluYXRpb24gYnVmZmVyLgo+ICsg Kgo+ICsgKiBFYWNoIHN5bmNfZmlsZSBtYXkgaGF2ZSBhIG5hbWUgYXNzaWduZWQgZWl0aGVyIGJ5 IHRoZSB1c2VyICh3aGVuIG1lcmdpbmcKPiArICogc3luY19maWxlcyB0b2dldGhlcikgb3IgY3Jl YXRlZCBmcm9tIHRoZSBmZW5jZSBpdCBjb250YWlucy4gSW4gdGhlIGxhdHRlcgo+ICsgKiBjYXNl IGNvbnN0cnVjdGlvbiBvZiB0aGUgbmFtZSBpcyBkZWZlcnJlZCB1bnRpbCB1c2UsIGFuZCBzbyBy ZXF1aXJlcwo+ICsgKiBzeW5jX2ZpbGVfZ2V0X25hbWUoKS4KPiArICoKPiArICogUmV0dXJuczog YSBzdHJpbmcgcmVwcmVzZW50aW5nIHRoZSBuYW1lLgo+ICsgKi8KPiArY2hhciAqc3luY19maWxl X2dldF9uYW1lKHN0cnVjdCBzeW5jX2ZpbGUgKnN5bmNfZmlsZSwgY2hhciAqYnVmLCBpbnQgbGVu KQo+ICt7Cj4gKwlpZiAoc3luY19maWxlLT51c2VyX25hbWVbMF0pIHsKPiArCQlzdHJsY3B5KGJ1 Ziwgc3luY19maWxlLT51c2VyX25hbWUsIGxlbik7Cj4gKwl9IGVsc2Ugewo+ICsJCXN0cnVjdCBk bWFfZmVuY2UgKmZlbmNlID0gc3luY19maWxlLT5mZW5jZTsKPiArCj4gKwkJc25wcmludGYoYnVm LCBsZW4sICIlcy0lcyVsbHUtJWQiLAo+ICsJCQkgZmVuY2UtPm9wcy0+Z2V0X2RyaXZlcl9uYW1l KGZlbmNlKSwKPiArCQkJIGZlbmNlLT5vcHMtPmdldF90aW1lbGluZV9uYW1lKGZlbmNlKSwKPiAr CQkJIGZlbmNlLT5jb250ZXh0LAo+ICsJCQkgZmVuY2UtPnNlcW5vKTsKPiArCX0KPiArCj4gKwly ZXR1cm4gYnVmOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHN5bmNfZmlsZV9zZXRfZmVuY2Uoc3Ry dWN0IHN5bmNfZmlsZSAqc3luY19maWxlLAo+ICAJCQkgICAgICAgc3RydWN0IGRtYV9mZW5jZSAq KmZlbmNlcywgaW50IG51bV9mZW5jZXMpCj4gIHsKPiBAQCAtMjY2LDcgKzI5MSw3IEBAIHN0YXRp YyBzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGVfbWVyZ2UoY29uc3QgY2hhciAqbmFtZSwgc3Ry dWN0IHN5bmNfZmlsZSAqYSwKPiAgCQlnb3RvIGVycjsKPiAgCX0KPiAgCj4gLQlzdHJsY3B5KHN5 bmNfZmlsZS0+bmFtZSwgbmFtZSwgc2l6ZW9mKHN5bmNfZmlsZS0+bmFtZSkpOwo+ICsJc3RybGNw eShzeW5jX2ZpbGUtPnVzZXJfbmFtZSwgbmFtZSwgc2l6ZW9mKHN5bmNfZmlsZS0+dXNlcl9uYW1l KSk7Cj4gIAlyZXR1cm4gc3luY19maWxlOwo+ICAKPiAgZXJyOgo+IEBAIC00MTksNyArNDQ0LDcg QEAgc3RhdGljIGxvbmcgc3luY19maWxlX2lvY3RsX2ZlbmNlX2luZm8oc3RydWN0IHN5bmNfZmls ZSAqc3luY19maWxlLAo+ICAJfQo+ICAKPiAgbm9fZmVuY2VzOgo+IC0Jc3RybGNweShpbmZvLm5h bWUsIHN5bmNfZmlsZS0+bmFtZSwgc2l6ZW9mKGluZm8ubmFtZSkpOwo+ICsJc3luY19maWxlX2dl dF9uYW1lKHN5bmNfZmlsZSwgaW5mby5uYW1lLCBzaXplb2YoaW5mby5uYW1lKSk7Cj4gIAlpbmZv LnN0YXR1cyA9IGRtYV9mZW5jZV9pc19zaWduYWxlZChzeW5jX2ZpbGUtPmZlbmNlKTsKPiAgCWlu Zm8ubnVtX2ZlbmNlcyA9IG51bV9mZW5jZXM7Cj4gIAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xp bnV4L3N5bmNfZmlsZS5oIGIvaW5jbHVkZS9saW51eC9zeW5jX2ZpbGUuaAo+IGluZGV4IGQzN2Jl ZWZkZmJkNS4uNTIyNmQ2MmFlOTFiIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvbGludXgvc3luY19m aWxlLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L3N5bmNfZmlsZS5oCj4gQEAgLTIzLDcgKzIzLDcg QEAKPiAgLyoqCj4gICAqIHN0cnVjdCBzeW5jX2ZpbGUgLSBzeW5jIGZpbGUgdG8gZXhwb3J0IHRv IHRoZSB1c2Vyc3BhY2UKPiAgICogQGZpbGU6CQlmaWxlIHJlcHJlc2VudGluZyB0aGlzIGZlbmNl Cj4gLSAqIEBuYW1lOgkJbmFtZSBvZiBzeW5jX2ZpbGUuICBVc2VmdWwgZm9yIGRlYnVnZ2luZwo+ ICsgKiBAdXNlcl9uYW1lOgkJbmFtZSBvZiBzeW5jX2ZpbGUuICBVc2VmdWwgZm9yIGRlYnVnZ2lu Zwo+ICAgKiBAc3luY19maWxlX2xpc3Q6CW1lbWJlcnNoaXAgaW4gZ2xvYmFsIGZpbGUgbGlzdAo+ ICAgKiBAd3E6CQkJd2FpdCBxdWV1ZSBmb3IgZmVuY2Ugc2lnbmFsaW5nCj4gICAqIEBmZW5jZToJ CWZlbmNlIHdpdGggdGhlIGZlbmNlcyBpbiB0aGUgc3luY19maWxlCj4gQEAgLTMxLDcgKzMxLDcg QEAKPiAgICovCj4gIHN0cnVjdCBzeW5jX2ZpbGUgewo+ICAJc3RydWN0IGZpbGUJCSpmaWxlOwo+ IC0JY2hhcgkJCW5hbWVbMzJdOwoKTWF5YmUgaW5saW5lIGtlcm5lbGRvYyBhbiBleHBsYWluIGEg Yml0IGJldHRlciB3aGF0J3MgZ29pbmcgb246CgoJLyoqCgkgKiBAdXNlcl9uYW1lOgoJICoKCSAq IE5hbWUgb2YgdGhlIHN5bmMgZmlsZSBwcm92aWRlZCBieSB1c2Vyc3BhY2UsIGZvciBtZXJnZWQg ZmVuY2VzLgoJICogT3RoZXJ3aXNlIGdlbmVyYXRlZCB0aHJvdWdoIGRyaXZlciBjYWxsYmFja3Mg KGluIHdoaWNoIGNhc2UgdGhlCgkgKiBlbnRpcmUgYXJyYXkgaXMgMCkuCgkgKi8KCk1pZ2h0IGJl IG92ZXJraWxsLCBzbyBub3QgZ29pbmcgdG8gaW5zaXN0IGF0IGFsbC4gRWl0aGVyIHdheToKClJl dmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKUGxzIHBv a2UgR3VzdGF2byBvciBTdW1pdHMgdG8gYWxzbyBjaGVjayBpdCBhbmQgcGljayBpdCB1cC4KClRo YW5rcywgRGFuaWVsCgo+ICsJY2hhcgkJCXVzZXJfbmFtZVszMl07Cj4gICNpZmRlZiBDT05GSUdf REVCVUdfRlMKPiAgCXN0cnVjdCBsaXN0X2hlYWQJc3luY19maWxlX2xpc3Q7Cj4gICNlbmRpZgo+ IEBAIC00Niw1ICs0Niw2IEBAIHN0cnVjdCBzeW5jX2ZpbGUgewo+ICAKPiAgc3RydWN0IHN5bmNf ZmlsZSAqc3luY19maWxlX2NyZWF0ZShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSk7Cj4gIHN0cnVj dCBkbWFfZmVuY2UgKnN5bmNfZmlsZV9nZXRfZmVuY2UoaW50IGZkKTsKPiArY2hhciAqc3luY19m aWxlX2dldF9uYW1lKHN0cnVjdCBzeW5jX2ZpbGUgKnN5bmNfZmlsZSwgY2hhciAqYnVmLCBpbnQg bGVuKTsKPiAgCj4gICNlbmRpZiAvKiBfTElOVVhfU1lOQ19IICovCj4gLS0gCj4gMi4xMS4wCj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==