From: "Michał Winiarski" <michal.winiarski@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 1/8] drm/i915: Remove misleading comment in request_alloc
Date: Tue, 23 May 2017 00:07:48 +0200 [thread overview]
Message-ID: <20170522220755.12400-1-michal.winiarski@intel.com> (raw)
Passing NULL ctx to request_alloc would lead to null-ptr-deref.
v2: Let's not replace the comment with a BUG_ON
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
drivers/gpu/drm/i915/i915_gem_request.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index 1ccf252..0d1e0d8 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -538,9 +538,6 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
*
* @engine: engine that we wish to issue the request on.
* @ctx: context that the request will be associated with.
- * This can be NULL if the request is not directly related to
- * any specific user context, in which case this function will
- * choose an appropriate context to use.
*
* Returns a pointer to the allocated request if successful,
* or an error code if not.
--
2.9.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-05-22 22:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 22:07 Michał Winiarski [this message]
2017-05-22 22:07 ` [PATCH 2/8] drm/i915/guc: Skip port assign on first iteration of GuC dequeue Michał Winiarski
2017-05-23 8:22 ` Chris Wilson
2017-05-22 22:07 ` [PATCH v3 3/8] drm/i915/guc: Submit GuC workitems containing coalesced requests Michał Winiarski
2017-05-23 0:07 ` Daniele Ceraolo Spurio
2017-05-23 7:55 ` Chris Wilson
2017-05-22 22:07 ` [PATCH v3 4/8] drm/i915/guc: Remove GuC wq reservation Michał Winiarski
2017-05-22 22:07 ` [PATCH v2 5/8] drm/i915/scheduler: Remember request priority throughout its lifetime Michał Winiarski
2017-05-22 22:07 ` [PATCH v2 6/8] drm/i915/scheduler: Split insert_request Michał Winiarski
2017-05-22 22:07 ` [PATCH v3 7/8] drm/i915/scheduler: Use priorities when resubmitting after reset Michał Winiarski
2017-05-22 22:07 ` [PATCH 8/8] HAX: Enable GuC submission for CI Michał Winiarski
2017-05-22 22:33 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/8] drm/i915: Remove misleading comment in request_alloc Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522220755.12400-1-michal.winiarski@intel.com \
--to=michal.winiarski@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.