From: Eric Biggers <ebiggers3@gmail.com>
To: linux-fscrypt@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH 1/4] ext4: don't bother checking for encryption key in ->mmap()
Date: Mon, 22 May 2017 17:39:42 -0700 [thread overview]
Message-ID: <20170523003945.14279-2-ebiggers3@gmail.com> (raw)
In-Reply-To: <20170523003945.14279-1-ebiggers3@gmail.com>
From: Eric Biggers <ebiggers@google.com>
Since only an open file can be mmap'ed, and we only allow open()ing an
encrypted file when its key is available, there is no need to check for
the key again before permitting each mmap().
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/ext4/file.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 831fd6beebf0..f0039867b086 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -345,13 +345,6 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma)
if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
return -EIO;
- if (ext4_encrypted_inode(inode)) {
- int err = fscrypt_get_encryption_info(inode);
- if (err)
- return 0;
- if (!fscrypt_has_encryption_key(inode))
- return -ENOKEY;
- }
file_accessed(file);
if (IS_DAX(file_inode(file))) {
vma->vm_ops = &ext4_dax_vm_ops;
--
2.13.0.303.g4ebf302169-goog
next prev parent reply other threads:[~2017-05-23 0:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 0:39 [PATCH 0/4] fscrypt: remove checks for encryption key after file open Eric Biggers
2017-05-23 0:39 ` Eric Biggers [this message]
2017-06-23 23:46 ` [PATCH 1/4] ext4: don't bother checking for encryption key in ->mmap() Theodore Ts'o
2017-06-23 23:46 ` Theodore Ts'o
2017-05-23 0:39 ` [PATCH 2/4] f2fs: " Eric Biggers
2017-05-23 0:39 ` Eric Biggers
2017-05-23 13:38 ` [f2fs-dev] " Chao Yu
2017-05-23 0:39 ` [PATCH 3/4] ubifs: " Eric Biggers
2017-05-23 0:39 ` Eric Biggers
2017-05-23 14:14 ` Richard Weinberger
2017-06-23 16:09 ` Theodore Ts'o
2017-06-23 17:18 ` Eric Biggers
2017-06-23 17:20 ` Richard Weinberger
2017-06-23 17:28 ` Theodore Ts'o
2017-06-23 17:28 ` Theodore Ts'o
2017-05-23 0:39 ` [PATCH 4/4] f2fs: don't bother checking for encryption key in ->write_iter() Eric Biggers
2017-05-23 0:39 ` Eric Biggers
2017-05-23 13:39 ` [f2fs-dev] " Chao Yu
2017-05-23 13:39 ` Chao Yu
2017-05-23 5:56 ` [PATCH 0/4] fscrypt: remove checks for encryption key after file open David Gstir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523003945.14279-2-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.