From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762147AbdEWH1p (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 03:27:45 -0400
Received: from mail-wm0-f45.google.com ([74.125.82.45]:35209 "EHLO
        mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933811AbdEWH1m (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 03:27:42 -0400
Date: Tue, 23 May 2017 09:27:38 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Slaby <jslaby@suse.cz>, Josh Poimboeuf <jpoimboe@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        live-patching@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH 7/7] DWARF: add the config option
Message-ID: <20170523072738.vi5sakodet2boddr@gmail.com>
References: <20170505122200.31436-1-jslaby@suse.cz>
 <20170505122200.31436-7-jslaby@suse.cz>
 <CA+55aFzEF_A1MzH8P8EX35FSci7UFj_+5LdsEFVai1DYtCk-Hg@mail.gmail.com>
 <20170507165524.cdxfuwbd5alr7v6k@treble>
 <alpine.LSU.2.20.1705092040370.26873@cbobk.fhfr.pm>
 <20170509192253.5lsb3yg2nwl2nrcw@treble>
 <18abff55-25d0-e783-8e1f-97bef42da1e3@suse.cz>
 <20170523070701.hxalap5q54nrn6z5@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170523070701.hxalap5q54nrn6z5@hirez.programming.kicks-ass.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, May 10, 2017 at 10:32:06AM +0200, Jiri Slaby wrote:
> > > But it does hurt, in the sense that the complicated format of DWARF CFI
> > > means the unwinder has to jump through a lot more hoops to read it.
> > 
> > Why that matters, actually? Unwinder is nothing to be performance
> > oriented. And if somebody is doing a lot of unwinding during runtime,
> > they can switch to in-this-case-faster FP unwinder.
> 
> perf (and ftrace) like the unwinder to be considered performance
> oriented.

Yes, and given how critical debugging is there's a kind of useful synergy here: 
overall the perf unwinder is run about 10 orders of magnitude more often than the 
debugging unwinder, so it's a very big help in shaking out unwinder/debug-info 
bugs and increasing robustness overall.

The 'price' for using the unwinder in perf is that it has to be fast.

Thanks,

	Ingo