From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Steve Twiss <stwiss.opensource@diasemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
LINUX-KERNEL <linux-kernel@vger.kernel.org>,
LINUX-SERIAL <linux-serial@vger.kernel.org>,
Lucas Stach <l.stach@pengutronix.de>,
Support Opensource <Support.Opensource@diasemi.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off
Date: Tue, 23 May 2017 16:37:15 +0200 [thread overview]
Message-ID: <20170523143715.yeg3gpkmvlu4l5kt@pengutronix.de> (raw)
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CD8D303@SW-EX-MBX02.diasemi.com>
Hallo Steve,
On Tue, May 23, 2017 at 02:28:11PM +0000, Steve Twiss wrote:
> On 23 May 2017 15:10, Uwe Kleine-König wrote:
> > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off
> > On Tue, May 23, 2017 at 01:17:26PM +0100, Steve Twiss wrote:
> > >
> > > Revert the commit e61c38d85b7392e ("serial: imx: setup DCEDTE early and
> > > ensure DCD and RI irqs to be off")
> > >
> > > The patch submitted to setup DCEDTE early and ensure DCD and RI irqs to
> > > be off, causes a serial console display problem the i.MX6Q SABRESD board.
> > > The console becomes unreadable and unwritable.
> > >
> > > Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
> > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> >
> > You're not the first to report this issue but you still have the chance
> > to be the first to test a suggested patch for it.
>
> I've just applied your patch against a clean linux-next/v4.12-rc2
> I added your patch ...
>
> > http://marc.info/?l=linux-serial&m=149434029912947&w=2
>
> (this one?)
>
> diff --git a/gp_sparse/linux-next/v4.12-rc2/drivers/tty/serial/imx.c b/gp_sparse/linux-next/v4.12-rc2/drivers/tty/serial/imx.c
> index 33509b4..2182548 100644
> --- a/gp_sparse/linux-next/v4.12-rc2/drivers/tty/serial/imx.c
> +++ b/gp_sparse/linux-next/v4.12-rc2/drivers/tty/serial/imx.c
> @@ -2193,9 +2193,14 @@ static int serial_imx_probe(struct platform_device *pdev)
> */
> writel(IMX21_UCR3_RXDMUXSEL | UCR3_ADNIMP | UCR3_DSR,
> sport->port.membase + UCR3);
> -
> } else {
> + unsigned long ucr3 = UCR3_DSR;
> +
> + if (!is_imx1_uart(sport))
> + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_ADNIMP;
> +
> writel(0, sport->port.membase + UFCR);
> + writel(ucr3, sport->port.membase + UCR3);
> }
>
> clk_disable_unprepare(sport->clk_ipg);
>
Yeah, that's the patch I meant.
> I've added that to my working directory, but I am still seeing the corrupted
> console output on the i.MX6 Q (quad) board.
I don't have a failing board (I think). So here are a few questions
about yours:
- how does the dts snippet for your failing device look like?
- This is not the device the console runs on, right?
- Can you initialize the device in the bootloader and check if it is
working there?
- Does it make a difference in Linux if the bootloader used the device
before?
- Can you dump the register space of the uart with v4.12-rc2 and
v4.12-rc2 + revert of e61c38d85b7392e?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2017-05-23 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 12:17 [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off Steve Twiss
2017-05-23 14:09 ` Uwe Kleine-König
2017-05-23 14:28 ` Steve Twiss
2017-05-23 14:37 ` Uwe Kleine-König [this message]
2017-05-23 15:01 ` Steve Twiss
2017-05-23 16:08 ` Uwe Kleine-König
2017-05-24 10:28 ` Steve Twiss
2017-05-24 11:57 ` Uwe Kleine-König
2017-05-23 16:26 ` Fabio Estevam
2017-05-24 10:32 ` Steve Twiss
2017-05-24 11:52 ` Fabio Estevam
2017-05-24 12:02 ` Uwe Kleine-König
2017-05-24 12:49 ` Steve Twiss
2017-05-24 13:52 ` Fabio Estevam
2017-05-24 16:08 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523143715.yeg3gpkmvlu4l5kt@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Support.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stwiss.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.