From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030626AbdEWOiq (ORCPT ); Tue, 23 May 2017 10:38:46 -0400 Received: from foss.arm.com ([217.140.101.70]:52842 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965197AbdEWOip (ORCPT ); Tue, 23 May 2017 10:38:45 -0400 Date: Tue, 23 May 2017 15:38:42 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Daniel Vetter , Jani Nikula , Brian Starkey , Sean Paul , DRI devel , LKML , Ville =?utf-8?B?U3lyasOkbMOk?= , Eric Anholt Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors Message-ID: <20170523143842.GA7799@e110455-lin.cambridge.arm.com> References: <20170515172057.30315-1-Liviu.Dudau@arm.com> <20170523163355.45756354@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170523163355.45756354@bbrezillon> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > Hi Liviu, Hi Boris, > > On Mon, 15 May 2017 18:20:55 +0100 > Liviu Dudau wrote: > > > Hi, > > > > This is v5 of the writeback connector series. Boris Brezillon thought > > that having to explicitly instantiate an encoder when using drm_writeback_connector > > is a bit too cumbersome, so I'm pushing out this version where we embed > > a virtual encoder inside drm_writeback_connector in order to satisfy the > > DRM framework. The caller of drm_writeback_connector_init() can control > > the embedded encoder by passing the drm_encoder_helper_funcs to be used. > > > > Comments are welcome on the suitability of this series. > > Whole series is: > > Reviewed-by: Boris Brezillon > Tested-by: Boris Brezillon > > Note that I tested it with the kms_writeback igt tests (available in > your branch [1]). Thanks a lot! Now that you seem to be happy with the series (right?) I'll try to push the kms_writeback tests into igt and get this series accepted. Best regards, Liviu > > I'll post the VC4 changes soon. > > Thanks, > > Boris > > > > > Best regards, > > Liviu > > > > Brian Starkey (2): > > drm: Add writeback connector type > > drm: writeback: Add out-fences for writeback connectors > > > > Documentation/gpu/drm-kms.rst | 9 + > > drivers/gpu/drm/Makefile | 2 +- > > drivers/gpu/drm/drm_atomic.c | 229 ++++++++++++++++++++++- > > drivers/gpu/drm/drm_atomic_helper.c | 6 + > > drivers/gpu/drm/drm_connector.c | 4 +- > > drivers/gpu/drm/drm_writeback.c | 362 ++++++++++++++++++++++++++++++++++++ > > include/drm/drm_atomic.h | 11 ++ > > include/drm/drm_connector.h | 13 ++ > > include/drm/drm_mode_config.h | 22 +++ > > include/drm/drm_writeback.h | 127 +++++++++++++ > > include/uapi/drm/drm_mode.h | 1 + > > 11 files changed, 775 insertions(+), 11 deletions(-) > > create mode 100644 drivers/gpu/drm/drm_writeback.c > > create mode 100644 include/drm/drm_writeback.h > > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liviu Dudau Subject: Re: [PATCH v5 0/2] drm: Introduce writeback connectors Date: Tue, 23 May 2017 15:38:42 +0100 Message-ID: <20170523143842.GA7799@e110455-lin.cambridge.arm.com> References: <20170515172057.30315-1-Liviu.Dudau@arm.com> <20170523163355.45756354@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id E98816E295 for ; Tue, 23 May 2017 14:38:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170523163355.45756354@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Brezillon Cc: LKML , DRI devel , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMjMsIDIwMTcgYXQgMDQ6MzM6NTVQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9u IHdyb3RlOgo+IEhpIExpdml1LAoKSGkgQm9yaXMsCgo+IAo+IE9uIE1vbiwgMTUgTWF5IDIwMTcg MTg6MjA6NTUgKzAxMDAKPiBMaXZpdSBEdWRhdSA8TGl2aXUuRHVkYXVAYXJtLmNvbT4gd3JvdGU6 Cj4gCj4gPiBIaSwKPiA+IAo+ID4gVGhpcyBpcyB2NSBvZiB0aGUgd3JpdGViYWNrIGNvbm5lY3Rv ciBzZXJpZXMuIEJvcmlzIEJyZXppbGxvbiB0aG91Z2h0Cj4gPiB0aGF0IGhhdmluZyB0byBleHBs aWNpdGx5IGluc3RhbnRpYXRlIGFuIGVuY29kZXIgd2hlbiB1c2luZyBkcm1fd3JpdGViYWNrX2Nv bm5lY3Rvcgo+ID4gaXMgYSBiaXQgdG9vIGN1bWJlcnNvbWUsIHNvIEknbSBwdXNoaW5nIG91dCB0 aGlzIHZlcnNpb24gd2hlcmUgd2UgZW1iZWQKPiA+IGEgdmlydHVhbCBlbmNvZGVyIGluc2lkZSBk cm1fd3JpdGViYWNrX2Nvbm5lY3RvciBpbiBvcmRlciB0byBzYXRpc2Z5IHRoZQo+ID4gRFJNIGZy YW1ld29yay4gVGhlIGNhbGxlciBvZiBkcm1fd3JpdGViYWNrX2Nvbm5lY3Rvcl9pbml0KCkgY2Fu IGNvbnRyb2wKPiA+IHRoZSBlbWJlZGRlZCBlbmNvZGVyIGJ5IHBhc3NpbmcgdGhlIGRybV9lbmNv ZGVyX2hlbHBlcl9mdW5jcyB0byBiZSB1c2VkLgo+ID4gCj4gPiBDb21tZW50cyBhcmUgd2VsY29t ZSBvbiB0aGUgc3VpdGFiaWxpdHkgb2YgdGhpcyBzZXJpZXMuCj4gCj4gV2hvbGUgc2VyaWVzIGlz Ogo+IAo+IFJldmlld2VkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVl LWVsZWN0cm9ucy5jb20+Cj4gVGVzdGVkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXpp bGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gCj4gTm90ZSB0aGF0IEkgdGVzdGVkIGl0IHdpdGgg dGhlIGttc193cml0ZWJhY2sgaWd0IHRlc3RzIChhdmFpbGFibGUgaW4KPiB5b3VyIGJyYW5jaCBb MV0pLgoKVGhhbmtzIGEgbG90ISBOb3cgdGhhdCB5b3Ugc2VlbSB0byBiZSBoYXBweSB3aXRoIHRo ZSBzZXJpZXMgKHJpZ2h0PykgSSdsbAp0cnkgdG8gcHVzaCB0aGUga21zX3dyaXRlYmFjayB0ZXN0 cyBpbnRvIGlndCBhbmQgZ2V0IHRoaXMgc2VyaWVzIGFjY2VwdGVkLgoKQmVzdCByZWdhcmRzLApM aXZpdQoKPiAKPiBJJ2xsIHBvc3QgdGhlIFZDNCBjaGFuZ2VzIHNvb24uCj4gCj4gVGhhbmtzLAo+ IAo+IEJvcmlzCj4gCj4gPiAKPiA+IEJlc3QgcmVnYXJkcywKPiA+IExpdml1Cj4gPiAKPiA+IEJy aWFuIFN0YXJrZXkgKDIpOgo+ID4gICBkcm06IEFkZCB3cml0ZWJhY2sgY29ubmVjdG9yIHR5cGUK PiA+ICAgZHJtOiB3cml0ZWJhY2s6IEFkZCBvdXQtZmVuY2VzIGZvciB3cml0ZWJhY2sgY29ubmVj dG9ycwo+ID4gCj4gPiAgRG9jdW1lbnRhdGlvbi9ncHUvZHJtLWttcy5yc3QgICAgICAgfCAgIDkg Kwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9NYWtlZmlsZSAgICAgICAgICAgIHwgICAyICstCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAgfCAyMjkgKysrKysrKysrKysrKysr KysrKysrKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8ICAgNiAr Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYyAgICAgfCAgIDQgKy0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRlYmFjay5jICAgICB8IDM2MiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiA+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljLmggICAgICAg ICAgICB8ICAxMSArKwo+ID4gIGluY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCAgICAgICAgIHwg IDEzICsrCj4gPiAgaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmggICAgICAgfCAgMjIgKysr Cj4gPiAgaW5jbHVkZS9kcm0vZHJtX3dyaXRlYmFjay5oICAgICAgICAgfCAxMjcgKysrKysrKysr KysrKwo+ID4gIGluY2x1ZGUvdWFwaS9kcm0vZHJtX21vZGUuaCAgICAgICAgIHwgICAxICsKPiA+ ICAxMSBmaWxlcyBjaGFuZ2VkLCA3NzUgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4g PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMKPiA+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9kcm0vZHJtX3dyaXRlYmFjay5oCj4gPiAKPiAK Ci0tIAo9PT09PT09PT09PT09PT09PT09PQp8IEkgd291bGQgbGlrZSB0byB8CnwgZml4IHRoZSB3 b3JsZCwgIHwKfCBidXQgdGhleSdyZSBub3QgfAp8IGdpdmluZyBtZSB0aGUgICB8CiBcIHNvdXJj ZSBjb2RlISAgLwogIC0tLS0tLS0tLS0tLS0tLQogICAgwq9cXyjjg4QpXy/CrwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK