From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH] drm/i915: prevent generating unusable gvt build which no
 mpt module is selected
Date: Wed, 24 May 2017 17:17:30 +0800
Message-ID: <20170524091730.wl3gfmeo6v4oy5cv@zhen-hp.sh.intel.com>
References: <1495615839-20797-1-git-send-email-changbin.du@intel.com>
Reply-To: Zhenyu Wang <zhenyuw@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0484270952=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1495615839-20797-1-git-send-email-changbin.du@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: changbin.du@intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, intel-gvt-dev@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============0484270952==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="xcqctwpjokgushn2"
Content-Disposition: inline


--xcqctwpjokgushn2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2017.05.24 16:50:39 +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>=20
> At least we need one MPT module (currently only have one) selected
> to get GVTg functional. When GVTg is enabled while no MPT selected,
> the build just includes useless GVTg code. This doesn't make sense.
>

The reason was that we tried to merge gvt device model in upstream
first while finishing KVMGT part later. I'm ok with this now.

> With this patch, a submenut is created under i915 as below:
>   -*- Enable Intel GVT-g graphics virtualization host support
>   <M> Enable KVM/VFIO support for Intel GVT-g
>=20
> If no MPT is selected, GVTg will be disabled automatically.
>   < > Enable KVM/VFIO support for Intel GVT-g
>=20
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
>  drivers/gpu/drm/i915/Kconfig | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index a5cd5da..e380a5d 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -91,12 +91,15 @@ config DRM_I915_USERPTR
> =20
>  	  If in doubt, say "Y".
> =20
> +menu "Intel GVT-g graphics virtualization host support"
> +	depends on DRM_I915
> +	depends on 64BIT
> +
>  config DRM_I915_GVT
> -        bool "Enable Intel GVT-g graphics virtualization host support"
> -        depends on DRM_I915
> -        depends on 64BIT
> -        default n
> -        help
> +	bool "Enable Intel GVT-g graphics virtualization host support"
> +	default n
> +	depends on DRM_I915_GVT_KVMGT
> +	help
>  	  Choose this option if you want to enable Intel GVT-g graphics
>  	  virtualization technology host support with integrated graphics.
>  	  With GVT-g, it's possible to have one integrated graphics
> @@ -116,13 +119,14 @@ config DRM_I915_GVT
> =20
>  config DRM_I915_GVT_KVMGT
>  	tristate "Enable KVM/VFIO support for Intel GVT-g"
> -	depends on DRM_I915_GVT
> +	select DRM_I915_GVT
>  	depends on KVM
>  	depends on VFIO_MDEV && VFIO_MDEV_DEVICE
>  	default n
>  	help
>  	  Choose this option if you want to enable KVMGT support for
>  	  Intel GVT-g.
> +endmenu
> =20
>  menu "drm/i915 Debugging"
>  depends on DRM_I915
> --=20
> 2.7.4
>=20

--=20
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

--xcqctwpjokgushn2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCWSVPqgAKCRCxBBozTXgY
J+kJAKCPdaS53y8Jg1Xtw2jgDIVHR3iZ+gCgkZJPQgjPdY1SZECRz1arv1zE+YY=
=49K/
-----END PGP SIGNATURE-----

--xcqctwpjokgushn2--

--===============0484270952==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0484270952==--