From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Du, Changbin" Subject: Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected Date: Wed, 24 May 2017 17:36:56 +0800 Message-ID: <20170524093656.GA23626@intel.com> References: <1495615839-20797-1-git-send-email-changbin.du@intel.com> <20170524092131.GA21114@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0829813056==" Return-path: In-Reply-To: <20170524092131.GA21114@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , changbin.du@intel.com, daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, zhenyuw@linux.intel.com List-Id: dri-devel@lists.freedesktop.org --===============0829813056== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 24, 2017 at 10:21:31AM +0100, Chris Wilson wrote: > On Wed, May 24, 2017 at 04:50:39PM +0800, changbin.du@intel.com wrote: > > From: Changbin Du > >=20 > > At least we need one MPT module (currently only have one) selected > > to get GVTg functional. When GVTg is enabled while no MPT selected, > > the build just includes useless GVTg code. This doesn't make sense. >=20 > See the Kconfig "choice" directive. > -Chris >=20 I was thought about "choice" as in mind firstly and that is good. But I thi= nk this is better since it make it totaly impossible that GVT is enabled while= no MPT. With "choice", if we forget disable GVT after unselect all MPTs, we st= ill compile GVT in but will never not use it. > --=20 > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > intel-gvt-dev mailing list > intel-gvt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev --=20 Thanks, Changbin Du --9amGYk9869ThD9tj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZJVQ4AAoJEAanuZwLnPNU4MMIAKwIMf6nIGGnS31/RPe0B7rZ oK7xY8+DK2hpAXFYdhL0GMk2OtZsyMMWjqU1KiUOujzUKqH7B2JyIQmaaS7Nz/ng vteM7TIxPpPo3BMGlN6mJhylcaRvrq4X4AwbRIBTgICCLPJP4V2Kw3q0lR97alzZ E0op5/kJbyvRE0z2zm4UB3aPz9vismnonK1JtHpLH2Eg1P8Jp/1uSgtkV0SJS5qs nLnv+JvZgC2vz4K0jnwSP1fx3WLiZxA8CpERvCQ8XVEvf2s33fGVLiH8sSxYTwG4 ysDexiWcsZqcaVhaHzOQadRDM1gxvnuhiNuoYoXeSGCpMP7cG2IE6Z/MDEuLvv8= =9I61 -----END PGP SIGNATURE----- --9amGYk9869ThD9tj-- --===============0829813056== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0829813056==--