From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941107AbdEXVcI (ORCPT ); Wed, 24 May 2017 17:32:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45290 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941010AbdEXVcG (ORCPT ); Wed, 24 May 2017 17:32:06 -0400 Date: Wed, 24 May 2017 14:32:05 -0700 From: Andrew Morton To: Matthias Kaehlcke Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Douglas Anderson , Mark Brown , Ingo Molnar , David Miller Subject: Re: [patch] compiler, clang: suppress warning for unused static inline functions Message-Id: <20170524143205.cae1a02ab2ad7348c1a59e0c@linux-foundation.org> In-Reply-To: <20170524212229.GR141096@google.com> References: <20170524212229.GR141096@google.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2017 14:22:29 -0700 Matthias Kaehlcke wrote: > I'm not a kernel maintainer, so it's not my decision whether this > warning should be silenced, my personal opinion is that it's benfits > outweigh the inconveniences of dealing with half-false positives, > generally caused by the heavy use of #ifdef by the kernel itself. Please resend and include this info in the changelog. Describe instances where this warning has resulted in actual runtime or developer-visible benefits. Where possible an appropriate I suggest it is better to move the offending function into a header file, rather than adding ifdefs. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id AB4976B0292 for ; Wed, 24 May 2017 17:32:08 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id m5so205835224pfc.1 for ; Wed, 24 May 2017 14:32:08 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id g10si3493228plj.120.2017.05.24.14.32.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 14:32:08 -0700 (PDT) Date: Wed, 24 May 2017 14:32:05 -0700 From: Andrew Morton Subject: Re: [patch] compiler, clang: suppress warning for unused static inline functions Message-Id: <20170524143205.cae1a02ab2ad7348c1a59e0c@linux-foundation.org> In-Reply-To: <20170524212229.GR141096@google.com> References: <20170524212229.GR141096@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Matthias Kaehlcke Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Douglas Anderson , Mark Brown , Ingo Molnar , David Miller On Wed, 24 May 2017 14:22:29 -0700 Matthias Kaehlcke wrote: > I'm not a kernel maintainer, so it's not my decision whether this > warning should be silenced, my personal opinion is that it's benfits > outweigh the inconveniences of dealing with half-false positives, > generally caused by the heavy use of #ifdef by the kernel itself. Please resend and include this info in the changelog. Describe instances where this warning has resulted in actual runtime or developer-visible benefits. Where possible an appropriate I suggest it is better to move the offending function into a header file, rather than adding ifdefs. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org