From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: i40e igb_uio: reset pci on process exit
Date: Thu, 25 May 2017 11:42:42 -0700
Message-ID: <20170525114242.3c6ac1b7@xeon-e3>
References: <106841857.Z7q1jSDIte@polaris>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
To: Gregory Etelson <gregory@weka.io>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 4619499D5
 for <dev@dpdk.org>; Thu, 25 May 2017 20:42:50 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id n23so174903494pfb.2
 for <dev@dpdk.org>; Thu, 25 May 2017 11:42:50 -0700 (PDT)
In-Reply-To: <106841857.Z7q1jSDIte@polaris>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 24 May 2017 14:22:11 +0300
Gregory Etelson <gregory@weka.io> wrote:

>  
> +static int
> +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> +{
> +       int ret;
> +       struct rte_uio_pci_dev *udev = info->priv;
> +       struct pci_dev *dev = udev->pdev;
> +       ret = __pci_reset_function(dev);
> +       dev_info(&dev->dev, "pci_reset_function %s \n",
> +                 ret == 0 ? "succeded" : "failed");
> +       return 0;
> +}
> +
> +

Patch in general looks ok, but:
 * no Signed-off
 * whitespace issues
 * doesn't pass kernel coding style
 * don't log on success, why log at all??