From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDx7k-0001OC-0h for qemu-devel@nongnu.org; Thu, 25 May 2017 14:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDx7g-0003AO-Qi for qemu-devel@nongnu.org; Thu, 25 May 2017 14:04:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDx7g-00039l-KS for qemu-devel@nongnu.org; Thu, 25 May 2017 14:04:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C14B780460 for ; Thu, 25 May 2017 18:04:30 +0000 (UTC) Date: Thu, 25 May 2017 15:04:26 -0300 From: Eduardo Habkost Message-ID: <20170525180426.GR32274@thinpad.lan.raisama.net> References: <20170513033316.22395-1-ehabkost@redhat.com> <20170513033316.22395-2-ehabkost@redhat.com> <87d1az64ab.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d1az64ab.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , Thomas Huth , "Daniel P. Berrange" On Tue, May 23, 2017 at 04:23:08PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Keep the Popen object around to we can query its exit code later. > > > > To keep the existing 'self._popen is None' checks working, add a > > is_running() method, that will check if the process is still running. > > > > Signed-off-by: Eduardo Habkost > > Looks harmless enough. Have you tested the scripts using this module > still work? Now I did. :) I see only two users of qemu.py and qtest.py: tests/migration/guestperf/engine.py:import qemu tests/qemu-iotests/iotests.py:import qtest I just tested both using: $ make check-tests/qemu-iotests-quick.sh $ make tests/migration/initrd-stress.img PTHREAD_LIB=-pthread $ ./tests/migration/guestperf.py > /tmp/guestperf.json and they seem to be working. (It looks like there's no Makefile rule to run guestperf.py) BTW, it seems to be impossible to build initrd-stress.img on a out-of-tree build. I had to run ./configure inside the source tree to be able to run guestperf.py. -- Eduardo