All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 05/19] cdrom: Check private request size before attaching to a queue
Date: Fri, 26 May 2017 08:08:13 +0200	[thread overview]
Message-ID: <20170526060813.GE18424@lst.de> (raw)
In-Reply-To: <20170525184327.23570-6-bart.vanassche@sandisk.com>

On Thu, May 25, 2017 at 11:43:13AM -0700, Bart Van Assche wrote:
> Since the cdrom driver only supports request queues for which
> struct scsi_request is the first member of their private request
> data, refuse to register block layer queues for which this is
> not the case.

Hmm.  I think we have a deeper issue there.  The cdrom layer usually
sends packets commands through the cdrom ops ->generic_packet
method, but one function (cdrom_read_cdda_bpc) seems to directly
send a scsi passthrough request.  It is only used if the cdda_method
is not CDDA_OLD, which is set if the cdrom_device_info structure
does not have a gendisk pointer hanging off it.  It seems like
the legacy cdrom drivers fall into that category and would be
broken by this change.

  reply	other threads:[~2017-05-26  6:08 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 18:43 [PATCH 00/19] Block layer patches for kernel v4.13 Bart Van Assche
2017-05-25 18:43 ` [PATCH 01/19] block: Avoid that blk_exit_rl() triggers a use-after-free Bart Van Assche
2017-05-26  6:01   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 02/19] block: Introduce queue flag QUEUE_FLAG_SCSI_PDU Bart Van Assche
2017-05-26  6:02   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 03/19] bsg: Check queue type before attaching to a queue Bart Van Assche
2017-05-26  6:02   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 04/19] pktcdvd: " Bart Van Assche
2017-05-26  6:03   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 05/19] cdrom: Check private request size " Bart Van Assche
2017-05-26  6:08   ` Christoph Hellwig [this message]
2017-05-26 15:50     ` Bart Van Assche
2017-05-28  8:32       ` hch
2017-05-25 18:43 ` [PATCH 06/19] nfsd: Check private request size before submitting a SCSI request Bart Van Assche
2017-05-25 18:48   ` J . Bruce Fields
2017-05-25 20:19     ` Bart Van Assche
2017-05-26  6:10       ` hch
2017-05-26 15:47         ` bfields
2017-05-26  6:10   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 07/19] scsi: Make scsi_ioctl_reset() pass the request queue pointer to blk_rq_init() Bart Van Assche
2017-05-25 18:43 ` [PATCH 08/19] block: Introduce request_queue.initialize_rq_fn() Bart Van Assche
2017-05-26  6:34   ` Christoph Hellwig
2017-05-26 23:56     ` Bart Van Assche
2017-05-28  8:34       ` hch
2017-05-28 16:12         ` Bart Van Assche
2017-05-28  8:37   ` Christoph Hellwig
2017-05-30 17:54     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 09/19] block: Make scsi_req_init() calls implicit Bart Van Assche
2017-05-28  8:38   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 10/19] blk-mq: Change blk_mq_hw_ctx.queue_rq_srcu into an array Bart Van Assche
2017-05-28  8:39   ` Christoph Hellwig
2017-05-28 16:36     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 11/19] blk-mq: Reduce blk_mq_hw_ctx size Bart Van Assche
2017-05-28  8:40   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 12/19] blk-mq: Initialize a request before assigning a tag Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-28 16:17     ` Bart Van Assche
2017-05-25 18:43 ` [PATCH 13/19] blk-mq: Fix the comment above blk_mq_quiesce_queue() Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 14/19] block: Add a comment above queue_lockdep_assert_held() Bart Van Assche
2017-05-28  8:42   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 15/19] block: Check locking assumptions at runtime Bart Van Assche
2017-05-25 18:43 ` [PATCH 16/19] block: Document what queue type each function is intended for Bart Van Assche
2017-05-25 18:43 ` [PATCH 17/19] blk-mq: Document locking assumptions Bart Van Assche
2017-05-25 18:43 ` [PATCH 18/19] block: Constify disk_type Bart Van Assche
2017-05-28  8:43   ` Christoph Hellwig
2017-05-25 18:43 ` [PATCH 19/19] block: Make request operation type argument declarations consistent Bart Van Assche
2017-05-28  8:43   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526060813.GE18424@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@sandisk.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.