From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970592AbdEZGw7 (ORCPT ); Fri, 26 May 2017 02:52:59 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34191 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965062AbdEZGw4 (ORCPT ); Fri, 26 May 2017 02:52:56 -0400 Date: Fri, 26 May 2017 08:52:52 +0200 From: Ingo Molnar To: "Levin, Alexander (Sasha Levin)" Cc: "linux-kernel@vger.kernel.org" , "ben@decadent.org.uk" , "a.p.zijlstra@chello.nl" , "tglx@linutronix.de" Subject: Re: [PATCH 00/21] liblockdep fixes for v4.12 Message-ID: <20170526065252.pj2ifnbb2wgosxfa@gmail.com> References: <20170525130005.5947-1-alexander.levin@verizon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170525130005.5947-1-alexander.levin@verizon.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Levin, Alexander (Sasha Levin) wrote: > MAINTAINERS | 2 +- > tools/Makefile | 8 +++-- > tools/include/linux/bitops.h | 10 ++++++ > tools/include/linux/err.h | 5 +++ > tools/include/linux/jhash.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tools/include/linux/sched/clock.h | 0 > tools/include/linux/sched/mm.h | 0 > tools/include/linux/sched/task.h | 0 > tools/include/linux/unaligned/packed_struct.h | 46 +++++++++++++++++++++++++++ > tools/lib/lockdep/Makefile | 9 +++--- > tools/lib/lockdep/lockdep.c | 17 ++++++++++ > tools/lib/lockdep/preload.c | 3 +- > tools/lib/lockdep/run_tests.sh | 8 ++--- > tools/lib/lockdep/uinclude/linux/bitops.h | 3 -- > tools/lib/lockdep/uinclude/linux/compiler.h | 2 ++ > tools/lib/lockdep/uinclude/linux/debug_locks.h | 2 +- > tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++--- > tools/lib/lockdep/uinclude/linux/kallsyms.h | 3 +- > tools/lib/lockdep/uinclude/linux/kernel.h | 20 ++++++++++-- > tools/lib/lockdep/uinclude/linux/lockdep.h | 26 ++++++++-------- > tools/lib/lockdep/uinclude/linux/module.h | 5 +++ > tools/lib/lockdep/uinclude/linux/rcu.h | 2 ++ > 22 files changed, 317 insertions(+), 37 deletions(-) > create mode 100644 tools/include/linux/jhash.h > create mode 100644 tools/include/linux/sched/clock.h > create mode 100644 tools/include/linux/sched/mm.h > create mode 100644 tools/include/linux/sched/task.h > create mode 100644 tools/include/linux/unaligned/packed_struct.h > delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h Yeah, so what needs to be fixed as well is for liblockdep to exclusively use tools/include/ (and extend those headers where required). perf already uses that method and it works well. liblockdep already uses tools/include/ in part, but even after I apply all your patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number of headers. I did a quick check - for example WARN_ON() et al is duplicated in tools/lib/lockdep/uinclude/linux/kernel.h. Thanks, Ingo