All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ben@decadent.org.uk" <ben@decadent.org.uk>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [PATCH 00/21] liblockdep fixes for v4.12
Date: Fri, 26 May 2017 10:57:53 +0000	[thread overview]
Message-ID: <20170526105930.nghwzltbdh4sk7mg@sasha-lappy> (raw)
In-Reply-To: <20170526065252.pj2ifnbb2wgosxfa@gmail.com>

On Fri, May 26, 2017 at 08:52:52AM +0200, Ingo Molnar wrote:
> 
> * Levin, Alexander (Sasha Levin) <alexander.levin@verizon.com> wrote:
> 
> >  MAINTAINERS                                    |   2 +-
> >  tools/Makefile                                 |   8 +++--
> >  tools/include/linux/bitops.h                   |  10 ++++++
> >  tools/include/linux/err.h                      |   5 +++
> >  tools/include/linux/jhash.h                    | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  tools/include/linux/sched/clock.h              |   0
> >  tools/include/linux/sched/mm.h                 |   0
> >  tools/include/linux/sched/task.h               |   0
> >  tools/include/linux/unaligned/packed_struct.h  |  46 +++++++++++++++++++++++++++
> >  tools/lib/lockdep/Makefile                     |   9 +++---
> >  tools/lib/lockdep/lockdep.c                    |  17 ++++++++++
> >  tools/lib/lockdep/preload.c                    |   3 +-
> >  tools/lib/lockdep/run_tests.sh                 |   8 ++---
> >  tools/lib/lockdep/uinclude/linux/bitops.h      |   3 --
> >  tools/lib/lockdep/uinclude/linux/compiler.h    |   2 ++
> >  tools/lib/lockdep/uinclude/linux/debug_locks.h |   2 +-
> >  tools/lib/lockdep/uinclude/linux/irqflags.h    |   8 ++---
> >  tools/lib/lockdep/uinclude/linux/kallsyms.h    |   3 +-
> >  tools/lib/lockdep/uinclude/linux/kernel.h      |  20 ++++++++++--
> >  tools/lib/lockdep/uinclude/linux/lockdep.h     |  26 ++++++++--------
> >  tools/lib/lockdep/uinclude/linux/module.h      |   5 +++
> >  tools/lib/lockdep/uinclude/linux/rcu.h         |   2 ++
> >  22 files changed, 317 insertions(+), 37 deletions(-)
> >  create mode 100644 tools/include/linux/jhash.h
> >  create mode 100644 tools/include/linux/sched/clock.h
> >  create mode 100644 tools/include/linux/sched/mm.h
> >  create mode 100644 tools/include/linux/sched/task.h
> >  create mode 100644 tools/include/linux/unaligned/packed_struct.h
> >  delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h
> 
> Yeah, so what needs to be fixed as well is for liblockdep to exclusively use 
> tools/include/ (and extend those headers where required).
> 
> perf already uses that method and it works well.
> 
> liblockdep already uses tools/include/ in part, but even after I apply all your 
> patches, there's still lib/lockdep/uinclude/ which appears to duplicate a number 
> of headers.
> 
> I did a quick check - for example WARN_ON() et al is duplicated in 
> tools/lib/lockdep/uinclude/linux/kernel.h.

Right, and as you can see from this patchset where we added to
tools/include/ when needed and removed from lib/lockdep/uinclude,
liblockdep is slowly creeping the "right" way.

perf, like liblockdep, didn't finish the switch to exclusively use
tools/include/ yet.

I can put more work into getting it done over the next few releases,
but it's not something I see as a critical fix for the upcoming
release.

-- 

Thanks,
Sasha

  reply	other threads:[~2017-05-26 10:58 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 12:58 [PATCH 00/21] liblockdep fixes for v4.12 Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 01/21] liblockdep: Fix undefined symbol prandom_u32 Levin, Alexander (Sasha Levin)
2017-06-05  9:01   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 02/21] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth Levin, Alexander (Sasha Levin)
2017-06-05  9:01   ` [tip:locking/core] tools/lib/lockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain/: Depth tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 03/21] liblockdep: Define the ARRAY_SIZE() macro Levin, Alexander (Sasha Levin)
2017-06-05  9:02   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 04/21] liblockdep: Enable -Wall by default Levin, Alexander (Sasha Levin)
2017-06-05  9:02   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 05/21] liblockdep: Fix 'unused value' warnings Levin, Alexander (Sasha Levin)
2017-06-05  9:03   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 06/21] liblockdep: Fix 'set but not used' warnings Levin, Alexander (Sasha Levin)
2017-06-05  9:04   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 07/21] liblockdep: Fix 'defined but not used' warning for init_utsname() Levin, Alexander (Sasha Levin)
2017-06-05  9:04   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 08/21] liblockdep: Remove -lpthread compiler option Levin, Alexander (Sasha Levin)
2017-06-05  9:05   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Vishal Thanki
2017-05-25 12:58 ` [PATCH 09/21] MAINTAINERS: update email for Sasha Levin Levin, Alexander (Sasha Levin)
2017-06-05  9:05   ` [tip:locking/core] MAINTAINERS: Update " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 10/21] tools: add install make target for liblockdep Levin, Alexander (Sasha Levin)
2017-06-05  9:06   ` [tip:locking/core] tools: Add " tip-bot for Alexander Sverdlin
2017-05-25 12:58 ` [PATCH 11/21] tools: liblockdep: Don't mix fd-based and stream IO Levin, Alexander (Sasha Levin)
2017-06-05  9:06   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Alexander Sverdlin
2017-05-25 12:58 ` [PATCH 12/21] tools: liblockdep: fix compilation for 4.11 Levin, Alexander (Sasha Levin)
2017-06-05  9:07   ` [tip:locking/core] tools/lib/lockdep: Fix " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 13/21] tools: liblockdep: Fix object file paths used in an out-of-tree build Levin, Alexander (Sasha Levin)
2017-06-05  9:07   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 14/21] tools: liblockdep: Remove double-quotes from soname Levin, Alexander (Sasha Levin)
2017-06-05  9:08   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 15/21] tools: liblockdep: Use LDFLAGS Levin, Alexander (Sasha Levin)
2017-06-05  9:09   ` [tip:locking/core] tools/lib/lockdep: " tip-bot for Ben Hutchings
2017-05-25 12:58 ` [PATCH 16/21] tools include: add empty include/linux/sched/mm.h Levin, Alexander (Sasha Levin)
2017-06-05  9:09   ` [tip:locking/core] tools/include: Add (mostly) " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 17/21] tools: liblockdep: include err.h Levin, Alexander (Sasha Levin)
2017-06-05  9:10   ` [tip:locking/core] tools/lib/lockdep: Include err.h tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 18/21] tools: liblockdep: add empty __is_[module,kernel]_percpu_address Levin, Alexander (Sasha Levin)
2017-06-05  9:10   ` [tip:locking/core] tools/lib/lockdep: Add " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 19/21] tools include: add IS_ERR_OR_NULL to err.h Levin, Alexander (Sasha Levin)
2017-06-05  9:11   ` [tip:locking/core] tools/include: Add " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 20/21] tools: liblockdep: add dummy current_gfp_context() Levin, Alexander (Sasha Levin)
2017-06-05  9:11   ` [tip:locking/core] tools/lib/lockdep: Add " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-25 12:58 ` [PATCH 21/21] tools: liblockdep: hide liblockdep output from test results Levin, Alexander (Sasha Levin)
2017-06-05  9:12   ` [tip:locking/core] tools/lib/lockdep: Hide " tip-bot for Levin, Alexander (Sasha Levin)
2017-05-26  6:52 ` [PATCH 00/21] liblockdep fixes for v4.12 Ingo Molnar
2017-05-26 10:57   ` Levin, Alexander (Sasha Levin) [this message]
2017-05-26 11:21     ` Ingo Molnar
2017-05-26 11:41       ` Levin, Alexander (Sasha Levin)
2017-05-28  9:11         ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2017-05-25 12:51 Levin, Alexander (Sasha Levin)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526105930.nghwzltbdh4sk7mg@sasha-lappy \
    --to=alexander.levin@verizon.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ben@decadent.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.