From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426255AbdEZLrW (ORCPT ); Fri, 26 May 2017 07:47:22 -0400 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:25804 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965488AbdEZLrS (ORCPT ); Fri, 26 May 2017 07:47:18 -0400 X-IronPort-Anti-Spam-Filtered: false From: "Levin, Alexander (Sasha Levin)" X-IronPort-AV: E=Sophos;i="5.38,396,1491264000"; d="scan'208";a="1454935616" To: Ingo Molnar CC: "linux-kernel@vger.kernel.org" , "ben@decadent.org.uk" , "a.p.zijlstra@chello.nl" , "tglx@linutronix.de" Subject: Re: [PATCH 00/21] liblockdep fixes for v4.12 Thread-Topic: [PATCH 00/21] liblockdep fixes for v4.12 Thread-Index: AQHS1hUMtE+9zuJIrUuyVIhE7vWpqg== Date: Fri, 26 May 2017 11:41:43 +0000 Message-ID: <20170526114320.ifwgj44xrfnuxyo3@sasha-lappy> References: <20170525130005.5947-1-alexander.levin@verizon.com> <20170526065252.pj2ifnbb2wgosxfa@gmail.com> <20170526105930.nghwzltbdh4sk7mg@sasha-lappy> <20170526112151.ssvrtq6zwerxuvgo@gmail.com> In-Reply-To: <20170526112151.ssvrtq6zwerxuvgo@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="us-ascii" Content-ID: <2211A8C94EE4964C83ADDC95BB2B5BDB@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4QBlQQA023936 On Fri, May 26, 2017 at 01:21:51PM +0200, Ingo Molnar wrote: > > * Levin, Alexander (Sasha Levin) wrote: > > > Right, and as you can see from this patchset where we added to > > tools/include/ when needed and removed from lib/lockdep/uinclude, > > liblockdep is slowly creeping the "right" way. > > > > perf, like liblockdep, didn't finish the switch to exclusively use > > tools/include/ yet. > > > > I can put more work into getting it done over the next few releases, > > but it's not something I see as a critical fix for the upcoming > > release. > > Since liblockdep was broken for an extended period of time I'd really > like to see this fixed before I apply any more patches. What does the build breakage has to do with converting the way we use headers? There's no broken functionality as far as I can tell, so why is the header thing defined as a "fix" to begin with? I also don't see a single tools/ project to exclusively use tools/include at this point. Would you rather keep liblockdep broken for the next couple of months until this is sorted? I really doubt I could get something (+ enough time to soak in -next) for v4.13, so we're looking at v4.14 at the earliest. -- Thanks, Sasha