From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 26 May 2017 08:38:59 -0400 Subject: [U-Boot] [PATCH 1/3] GPT: add accessor function for disk GUID In-Reply-To: <1495333675-14854-2-git-send-email-alison@peloton-tech.com> References: <1495333675-14854-1-git-send-email-alison@peloton-tech.com> <1495333675-14854-2-git-send-email-alison@peloton-tech.com> Message-ID: <20170526123859.GJ10782@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, May 20, 2017 at 07:27:53PM -0700, alison at peloton-tech.com wrote: > From: Alison Chaiken > > In order to read the GPT, modify the partition name strings, and then > write out a new GPT, the disk GUID is needed. While there is an > existing accessor for the partition UUIDs, there is none yet for the > disk GUID. > > Signed-off-by: Alison Chaiken Overall looks good, a few style things: > + if (namestr != NULL) > + setenv(namestr, disk_guid); You can just if (namestr) here [snip] > + } else if (strcmp(argv[1], "guid") == 0) { > + if (argc == 5) strcpy(varname, argv[4]); Go ahead and do this on multiple lines please. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: