From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037329AbdE0BQj (ORCPT ); Fri, 26 May 2017 21:16:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:45750 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1948716AbdEZVNb (ORCPT ); Fri, 26 May 2017 17:13:31 -0400 Date: Fri, 26 May 2017 23:13:28 +0200 From: "Luis R. Rodriguez" To: "Li, Yi" Cc: "Luis R. Rodriguez" , atull@kernel.org, Greg Kroah-Hartman , Daniel Wagner , David Woodhouse , rafal@milecki.pl, Arend Van Spriel , "Rafael J. Wysocki" , Moritz Fischer , Petr Mladek , Johannes Berg , Emmanuel Grumbach , Luciano Coelho , Kalle Valo , Andy Lutomirski , "AKASHI, Takahiro" , David Howells , Peter Jones , "linux-kernel@vger.kernel.org" , linux-fpga@vger.kernel.org Subject: Re: [PATCHv2 0/3] Enable no_cache flag to driver_data Message-ID: <20170526211328.GA8951@wotan.suse.de> References: <1495262819-981-1-git-send-email-yi1.li@linux.intel.com> <20170524190357.GB8951@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 04:05:43PM -0500, Li, Yi wrote: > hi Luis > > > On 5/25/2017 5:43 PM, Luis R. Rodriguez wrote: > > On Thu, May 25, 2017 at 3:30 PM, Li, Yi wrote: > > > This patch is for "disabling the cache" for streaming and iwlwifi case, > > > adding the test to verify the cache function should be a separate patch, > > > right? I can look more into the cache part. > > How can we know cache was disabled without first testing what having > > cache enabled could be like ? > > Understand the point, adding the test for cache enabled still cannot cover > the disable cache part though:-). Please give me couple days to think about > it. Maybe will first have a new patch to test the cache part, likely through > the debugfs as you suggested; then amend this series to complete the cache > disabling test part. Thanks for the insight. Sounds good! Luis