From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750844AbdE1Ezn (ORCPT ); Sun, 28 May 2017 00:55:43 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:40768 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdE1Ezl (ORCPT ); Sun, 28 May 2017 00:55:41 -0400 Date: Sat, 27 May 2017 21:55:22 -0700 From: Christoph Hellwig To: Kees Cook Cc: Christoph Hellwig , "kernel-hardening@lists.openwall.com" , Laura Abbott , "x86@kernel.org" , LKML , Bob Moore , Lv Zheng , "Rafael J. Wysocki" Subject: Re: [PATCH v2 11/20] randstruct: Disable randomization of ACPICA structs Message-ID: <20170528045522.GB5045@infradead.org> References: <1495829844-69341-1-git-send-email-keescook@chromium.org> <1495829844-69341-12-git-send-email-keescook@chromium.org> <20170527084246.GB26844@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2017 at 01:03:23PM -0700, Kees Cook wrote: > On Sat, May 27, 2017 at 1:42 AM, Christoph Hellwig wrote: > > On Fri, May 26, 2017 at 01:17:15PM -0700, Kees Cook wrote: > >> Since the ACPICA source is maintained externally to the kernel, we can > >> neither switch it to designated initializers nor mark it > >> __no_randomize_layout. Until ACPICA-upstream changes[1] land to handle the > >> designated initialization, explicitly skip it in the plugin. > >> > >> [1] https://github.com/acpica/acpica/pull/248 > > > > I'd just overried the ACPIA bullshit process and just include these > > changes, as they are a major improvement independent of any > > reandomization. > > Well... I'd rather not. It's been explicitly NAKed by them already, > which is why I sent the upstream solution (though it's being ignored > currently). Send it to linux-keernel again and we'll override their bulllshit. We can make exceptions from our coding style and preference just because they are idiots. And the whole ACPI mess needs urgent de-obsfucation anyway. From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 27 May 2017 21:55:22 -0700 From: Christoph Hellwig Message-ID: <20170528045522.GB5045@infradead.org> References: <1495829844-69341-1-git-send-email-keescook@chromium.org> <1495829844-69341-12-git-send-email-keescook@chromium.org> <20170527084246.GB26844@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [kernel-hardening] Re: [PATCH v2 11/20] randstruct: Disable randomization of ACPICA structs To: Kees Cook Cc: Christoph Hellwig , "kernel-hardening@lists.openwall.com" , Laura Abbott , "x86@kernel.org" , LKML , Bob Moore , Lv Zheng , "Rafael J. Wysocki" List-ID: On Sat, May 27, 2017 at 01:03:23PM -0700, Kees Cook wrote: > On Sat, May 27, 2017 at 1:42 AM, Christoph Hellwig wrote: > > On Fri, May 26, 2017 at 01:17:15PM -0700, Kees Cook wrote: > >> Since the ACPICA source is maintained externally to the kernel, we can > >> neither switch it to designated initializers nor mark it > >> __no_randomize_layout. Until ACPICA-upstream changes[1] land to handle the > >> designated initialization, explicitly skip it in the plugin. > >> > >> [1] https://github.com/acpica/acpica/pull/248 > > > > I'd just overried the ACPIA bullshit process and just include these > > changes, as they are a major improvement independent of any > > reandomization. > > Well... I'd rather not. It's been explicitly NAKed by them already, > which is why I sent the upstream solution (though it's being ignored > currently). Send it to linux-keernel again and we'll override their bulllshit. We can make exceptions from our coding style and preference just because they are idiots. And the whole ACPI mess needs urgent de-obsfucation anyway.